[nnpack] create a new port#16344
Merged
vicroms merged 17 commits intomicrosoft:masterfrom Apr 7, 2021
luncliff:port/nnpack
Merged
[nnpack] create a new port#16344vicroms merged 17 commits intomicrosoft:masterfrom luncliff:port/nnpack
vicroms merged 17 commits intomicrosoft:masterfrom
luncliff:port/nnpack
Conversation
Contributor
Author
This was referenced Apr 3, 2021
* there are no config for windows
There is a 'neon' backend, but it won't be considered for now
* use more correct expression
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
approved these changes
Apr 5, 2021
Contributor
|
LGTM, already tested on Linux and OSX, curious why the CI status is N/A. |
This was referenced Apr 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
There was no port request for this project.
This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the
libtorchport.Which triplets are supported/not supported? Have you updated the CI baseline?
Looks like it supports Linux, Mac, iOS, and Android. The PR targets only 2 triplets.
x64-osxx64-linuxThe project doesn't have a configuration for Windows. (
WIN32,AMD64,CMAKE_SYSTEM_NAME, etc.)Does your PR follow the maintainer guide?
The library doesn't have a tag/release.
vcpkg format-manifest... we use the date that the commit was accessed by you, formatted as
YYYY-MM-DD.