[pthreadpool] create a new port#16342
Merged
vicroms merged 8 commits intomicrosoft:masterfrom Apr 1, 2021
luncliff:port/pthreadpool
Merged
[pthreadpool] create a new port#16342vicroms merged 8 commits intomicrosoft:masterfrom luncliff:port/pthreadpool
vicroms merged 8 commits intomicrosoft:masterfrom
luncliff:port/pthreadpool
Conversation
Contributor
Author
|
This PR will be rebased when #16341 is merged. Will be ready for review after testing more triplets. |
NancyLi1013
suggested changes
Feb 26, 2021
NancyLi1013
approved these changes
Mar 1, 2021
Contributor
|
LGTM now, thanks for adding this port @luncliff. |
This was referenced Apr 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
There was no port request for this project.
This is one of the 3rd party libraries for the PyTorch project. The PR will be used for future support of the
libtorchport.Which triplets are supported/not supported? Have you updated the CI baseline?
The project has quite simple code. Expected to be portable according to its CI configuration, but need more tests.
x64-osxx64-linuxx64-windows,x86-windows,arm64-windows: runs static build on WindowsWork In Progress
Does your PR follow the maintainer guide?
The library has a tag, but it's too old. I snapshoted the source code with
"version-string": 2021-02-21vcpkg format-manifest... we use the date that the commit was accessed by you, formatted as
YYYY-MM-DD.