Skip to content

[gettext] Add feature tools#17010

Merged
vicroms merged 9 commits intomicrosoft:masterfrom
Neumann-A:add_gettext_tools
Apr 7, 2021
Merged

[gettext] Add feature tools#17010
vicroms merged 9 commits intomicrosoft:masterfrom
Neumann-A:add_gettext_tools

Conversation

@Neumann-A
Copy link
Copy Markdown
Contributor

@Neumann-A Neumann-A commented Apr 1, 2021 •
edited
Loading

required by some port to have gettext available.
Be warned: Building tools requires a long time.

supersedes #16612 @JackBoosY

@JackBoosY JackBoosY self-assigned this Apr 1, 2021
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 1, 2021
@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Apr 1, 2021

If you don't have enough time, I can handle this PR.

autoantwort
autoantwort reviewed Apr 1, 2021
View reviewed changes
@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Apr 2, 2021

@JackBoosY Seems like CI is stuck for this PR

JackBoosY
JackBoosY reviewed Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that only the following tools were generated:

autopoint       gettext         gettextize      msgcat          msgcomm         msgen           msgfilter       msggrep         msgmerge        msguniq         recode-sr-latin
envsubst        gettext.sh      msgattrib       msgcmp          msgconv         msgexec         msgfmt          msginit         msgunfmt        ngettext        xgettext

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Apr 6, 2021
@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Apr 7, 2021

Note that only the following tools were generated:

Only? isn't that everything? Autotools typically searches for xgettext and some of the msg* tools

@vicroms vicroms merged commit 3320069 into microsoft:master Apr 7, 2021
@Neumann-A Neumann-A deleted the add_gettext_tools branch April 7, 2021 20:33
@PhoebeHui PhoebeHui mentioned this pull request Apr 15, 2021
Closed
@JackBoosY JackBoosY mentioned this pull request Apr 18, 2021
Closed
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Apr 23, 2021

This regressed time to install gettext from 5 minutes to 45 minutes. :(

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Apr 23, 2021

Most expensive ports:
image

@Neumann-A
Copy link
Copy Markdown
Contributor Author

Neumann-A commented Apr 23, 2021

@BillyONeal This didn't regress gettext. Before only gettext-runtime was build. With tools everything gettext has to offer is build. That is a significant difference. But i agree that there should be something done to make it faster. As far as I remember mist of the time is spend compressing some archive?

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Apr 23, 2021

As far as I remember mist of the time is spend compressing some archive?

No idea. I do see a ton of .sh processes flying by though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@autoantwort autoantwort autoantwort left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Neumann-A @JackBoosY @BillyONeal @autoantwort @vicroms