Skip to content

[gettext] Add feature tools#16612

Closed
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/13518
Closed

[gettext] Add feature tools#16612
JackBoosY wants to merge 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/13518

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

Fixes #13518.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Mar 9, 2021
@Neumann-A
Copy link
Copy Markdown
Contributor

there are two scripts which use absolute paths somewhere arround gettext-tools/misc/*.in these need to be patched to calculated the prefix given the script installed path instead.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@Neumann-A I noticed that libtools didn't generated, what's wrong?

@autoantwort
Copy link
Copy Markdown
Contributor

autoantwort commented Mar 25, 2021

@Neumann-A I noticed that libtools didn't generated, what's wrong?

On my mac the follwing tools get generated: autopoint gettext msgattrib msgcat msgcmp msgcomm msgconv msgen msgexec msgfilter msgfmt msggrep msginit msgmerge msgunfmt msguniq ngettext recode-sr-latin xgettext gettextize envsubst

Comment on lines 81 to 82
file(COPY ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/gettext)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/gettext/COPYING ${CURRENT_PACKAGES_DIR}/share/gettext/copyright)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
file(COPY ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/gettext)
file(RENAME ${CURRENT_PACKAGES_DIR}/share/gettext/COPYING ${CURRENT_PACKAGES_DIR}/share/gettext/copyright)
file(INSTALL ${SOURCE_PATH}/COPYING DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)

@Neumann-A
Copy link
Copy Markdown
Contributor

Neumann-A commented Mar 30, 2021

@JackBoosY libtools is not part of gettext? autopoint is. (which is just a script)

autopoint.in and gettextize.in needs to be changed to have: (starting somewhere around line 28)

# Set variables
# - gettext_datadir     directory where the data files are stored.
prefix="$(dirname "$0")/../../../"
datarootdir="${prefix}/share/gettext"

to be relocatable. Otherwise they hardcode the absolute path

@JackBoosY JackBoosY closed this Apr 1, 2021
@JackBoosY JackBoosY deleted the dev/jack/13518 branch April 1, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[gettext] msgfmt (and other gettext bin tools) missing on macOS & Windows

4 participants