[osg] fix x64-windows-static-md builds#15374
Merged
dan-shaw merged 5 commits intomicrosoft:masterfrom Jan 21, 2021
Merged
Conversation
JackBoosY
suggested changes
Dec 30, 2020
JackBoosY
suggested changes
Jan 4, 2021
Contributor
|
Waiting for official reply. |
Contributor
Author
Does that mean I can't get a go-ahead to merge unless Is there a reason we'd like to hold off on the workaround patch here? |
Contributor
|
@ankurverma85 According to our policy, any critical changes to the source code must be approved by upstream. |
Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com>
Contributor
Author
|
Opened a pull request for the upstream patches |
Contributor
|
Waiting for official reply. |
Contributor
Author
Upstream PR merged |
JackBoosY
approved these changes
Jan 19, 2021
Contributor
|
Needs test all features. |
added 2 commits
January 19, 2021 01:07
JackBoosY
approved these changes
Jan 20, 2021
Contributor
|
Test all features successfully on |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jan 21, 2021
[osg] fix x64-windows-static-md builds (microsoft#15374)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? Fixes [osg, osgearth] x64-windows-static-md build failure #15301
Which triplets are supported/not supported? Have you updated the CI baseline?
Does your PR follow the maintainer guide?