Skip to content

[zziplib] Uses upstream CMakeLists.txt#15215

Merged
BillyONeal merged 8 commits intomicrosoft:masterfrom
longnguyen2004:zziplib-mingw
Dec 24, 2020
Merged

[zziplib] Uses upstream CMakeLists.txt#15215
BillyONeal merged 8 commits intomicrosoft:masterfrom
longnguyen2004:zziplib-mingw

Conversation

@longnguyen2004
Copy link
Copy Markdown
Contributor

@longnguyen2004 longnguyen2004 commented Dec 19, 2020

Describe the pull request

@longnguyen2004
Copy link
Copy Markdown
Contributor Author

longnguyen2004 commented Dec 19, 2020 •
edited
Loading

Can someone get osx, linux and uwp build logs for me?

@longnguyen2004 longnguyen2004 mentioned this pull request Dec 21, 2020
Merged
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 21, 2020

Please see the details here
https://dev.azure.com/vcpkg/public/_build/results?buildId=46773&view=artifacts&pathAsName=false&type=publishedArtifacts

Since there is something wrong on osx, we cannot get logs on osx now.

The failures on Linux:

CMake Error at zzip/CMakeLists.txt:315 (get_target_property):
  get_target_property() called with non-existent target "libzzipfseeko".


CMake Error at zzip/CMakeLists.txt:316 (get_target_property):
  get_target_property() called with non-existent target "libzzipfseeko".


CMake Error at zzip/CMakeLists.txt:317 (get_target_property):
  get_target_property() called with non-existent target "libzzipfseeko".


CMake Error at zzip/CMakeLists.txt:330 (get_target_property):
  get_target_property() called with non-existent target "libzzipmmapped".


CMake Error at zzip/CMakeLists.txt:331 (get_target_property):
  get_target_property() called with non-existent target "libzzipmmapped".


CMake Error at zzip/CMakeLists.txt:332 (get_target_property):
  get_target_property() called with non-existent target "libzzipmmapped".

The failures on uwp:

4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\err.c(70,20): error C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip/__dirent.h(174,12): error C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. (compiling source file D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\dir.c) [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\err.c(75,12): error C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip/__dirent.h(180,9): error C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. (compiling source file D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\dir.c) [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\err.c(87,16): error C4996: 'strerror': This function or variable may be unsafe. Consider using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip/__dirent.h(184,12): error C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. (compiling source file D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\dir.c) [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]
     4>D:\buildtrees\zziplib\src\97c6f3df29-1240d2902f.clean\zzip\plugin.c(45,6): error C4996: 'open': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _open. See online help for details. [D:\buildtrees\zziplib\x64-uwp-dbg\zzip\libzzip.vcxproj]

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels Dec 21, 2020
@longnguyen2004 longnguyen2004 mentioned this pull request Dec 22, 2020
Closed
NancyLi1013
NancyLi1013 suggested changes Dec 22, 2020
View reviewed changes
@vadi2
Copy link
Copy Markdown
Contributor

vadi2 commented Dec 22, 2020

Can you merge latest development? It fails on building the dependency zlib before it can get to zziplib.

@longnguyen2004
Copy link
Copy Markdown
Contributor Author

longnguyen2004 commented Dec 22, 2020 •
edited
Loading

@vadi2 Can you give me the build log?
Oh wait, you mean merge master into this? Sure

@vadi2
Copy link
Copy Markdown
Contributor

vadi2 commented Dec 22, 2020

Yeah.

vadi2
vadi2 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds OK

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Dec 23, 2020
@BillyONeal BillyONeal merged commit 6654632 into microsoft:master Dec 24, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 24, 2020

Thanks for getting us to use upstream things! :D

@longnguyen2004 longnguyen2004 deleted the zziplib-mingw branch December 24, 2020 01:29
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@longnguyen2004
[zziplib] Uses upstream CMakeLists.txt (microsoft#15215)
7047151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vadi2 vadi2 vadi2 approved these changes

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[zziplib] x64-mingw-dynamic build failure

4 participants

@longnguyen2004 @NancyLi1013 @vadi2 @BillyONeal