Skip to content

Print failing upload attempts in !debug.#15206

Merged
vicroms merged 1 commit intomicrosoft:masterfrom
BillyONeal:caching_upload_output
Dec 21, 2020
Merged

Print failing upload attempts in !debug.#15206
vicroms merged 1 commit intomicrosoft:masterfrom
BillyONeal:caching_upload_output

Conversation

@BillyONeal
Copy link
Copy Markdown
Member

Other changes:

  • Changed Strings::replace_all to use more StringView
  • Introduced Strings::inplace_replace_all for the common x = replace_all(move(x) pattern and tests
    -> Also fixed bug if the search string was empty consuming infinite memory!
  • Added many missing {}s in binarycaching.cpp

Other changes:
* Changed Strings::replace_all to use more StringView
* Introduced Strings::inplace_replace_all for the common x = replace_all(move(x) pattern and tests
-> Also fixed bug if the search string was empty consuming infinite memory!
* Added many missing {}s in binarycaching.cpp
@BillyONeal
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Dec 21, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 21, 2020
@vicroms vicroms merged commit d97eae3 into microsoft:master Dec 21, 2020
@BillyONeal BillyONeal deleted the caching_upload_output branch December 22, 2020 00:18
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
Other changes:
* Changed Strings::replace_all to use more StringView
* Introduced Strings::inplace_replace_all for the common x = replace_all(move(x) pattern and tests
-> Also fixed bug if the search string was empty consuming infinite memory!
* Added many missing {}s in binarycaching.cpp
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Other changes:
* Changed Strings::replace_all to use more StringView
* Introduced Strings::inplace_replace_all for the common x = replace_all(move(x) pattern and tests
-> Also fixed bug if the search string was empty consuming infinite memory!
* Added many missing {}s in binarycaching.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants