Write manifest "vcpkg install" output to stdout#15187
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Dec 21, 2020
Merged
Write manifest "vcpkg install" output to stdout#15187BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
strega-nil
reviewed
Dec 18, 2020
`ECHO_OUTPUT_VARIABLE` and `ECHO_ERROR_VARIABLE` were only added in CMake 3.18. This change prevents those parameters from being added to the `execute_process` command when using older versions of CMake.
|
|
strega-nil
approved these changes
Dec 18, 2020
JackBoosY
approved these changes
Dec 21, 2020
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pull request to this project, so there might be things I'm overlooking.
In c902748, the output from the
vcpkg installcommand run by manifest mode was written to a file. This had the side effect of no longer writing that output to stdout/err, which can be a very unfortunate change if your dependencies managed by vcpkg take a long time to install: you will sit there with the only output being "Running vcpkg install" at the very beginning, and "Running vcpkg install - done" at the very end. Since there is otherwise no progress indicator, I believe it beneficial to have thatvcpkg installoutput visible in the console.CMake's
execute_processfunctionality has support forECHO_OUTPUT_VARIABLEandECHO_ERROR_VARIABLE, but unfortunately these only apply to the variable output methods, not the file output methods. This pull request stores the output of thevcpkg installcommand into a new variable_VCPKG_MANIFEST_INSTALL_LOGTEXT, and then after thevcpkg installcommand is finished, the output is written into thevcpkg-manifest-install.logfile.Which triplets are supported/not supported? Have you updated the CI baseline?
No other changes were made besides vcpkg.cmake. I believe this question is intended for users who are making changes to ports.
Does your PR follow the maintainer guide?
I believe so, but again, my understanding is that this question is intended for people that are making changes to ports.