[cppmicroservices] Fix warning C4834#15177
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Dec 18, 2020
Cheney-W:dev/cheney/C4834
Merged
[cppmicroservices] Fix warning C4834#15177BillyONeal merged 1 commit intomicrosoft:masterfrom Cheney-W:dev/cheney/C4834
BillyONeal merged 1 commit intomicrosoft:masterfrom
Cheney-W:dev/cheney/C4834
Conversation
NancyLi1013
approved these changes
Dec 17, 2020
Member
|
Thanks! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Dec 18, 2020
[cppmicroservices] Fix warning C4834 (microsoft#15177)
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
Co-authored-by: Cheney-Wang <v-xincwa@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Since the change: microsoft/STL#1495 , [nodiscard] was added before some constructors, this change causes the warning C4834: discarding return value of function with 'nodiscard' attribute occurs when install port cppmicroservices.
The change of STL is by design, so I add a patch to modify the source code.