Skip to content

[civetweb] Disable extensive log output for debug builds#15168

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
gjasny:civetweb-disable-verbose-logging
Dec 18, 2020
Merged

[civetweb] Disable extensive log output for debug builds#15168
BillyONeal merged 1 commit intomicrosoft:masterfrom
gjasny:civetweb-disable-verbose-logging

Conversation

@gjasny
Copy link
Copy Markdown
Contributor

@gjasny gjasny commented Dec 16, 2020 •
edited
Loading

Hello,

this patch removes overly verbose output of civetweb in Debug builds. This output is unconditionally printed to stdout.

*** 1608147558.169509000 4595015104 mg_start2:19608: [listening_ports] -> [127.0.0.1:0]
*** 1608147558.169531000 4595015104 mg_start2:19608: [num_threads] -> [2]
*** 1608147558.169817000 123145365999616 consume_socket:18713: going idle
*** 1608147558.169847000 123145366114304 consume_socket:18713: going idle
*** 1608147558.171559000 123145366228992 accept_new_connection:19032: Accepted socket 7
*** 1608147558.171584000 123145366228992 produce_socket:18771: queued socket 7
*** 1608147558.171621000 123145365999616 consume_socket:18727: grabbed socket 7, going busy
*** 1608147558.171676000 123145365999616 worker_thread_run:18881: Start processing connection from 127.0.0.1
*** 1608147558.171685000 123145365999616 process_new_connection:18442: Start processing connection from 127.0.0.1
*** 1608147558.171689000 123145365999616 process_new_connection:18449: calling get_request (1 times for this connection)
*** 1608147558.171747000 123145365999616 switch_domain_context:13818: HTTP Host: 127.0.0.1
*** 1608147558.171757000 123145365999616 process_new_connection:18536: http: 1.1, error: none
*** 1608147558.171764000 123145365999616 handle_request:14354: URL: /metrics
*** 1608147558.171796000 123145365999616 open_auth_file:8754: fopen(/.htpasswd): No such file or directory
*** 1608147558.171808000 123145365999616 mg_send_http_error_impl:4939: Error 404 - [Not Found]
*** 1608147558.173098000 123145365999616 process_new_connection:18556: handle_request done
*** 1608147558.173122000 123145365999616 process_new_connection:18630: Done processing connection from 127.0.0.1 (0.000000 sec)
*** 1608147558.173163000 123145365999616 worker_thread_run:18950: Connection closed
*** 1608147558.173167000 123145365999616 consume_socket:18713: going idle
*** 1608147558.376629000 123145366228992 master_thread_run:19164: stopping workers
*** 1608147558.376686000 123145366114304 worker_thread_run:18978: exiting
*** 1608147558.376691000 123145365999616 worker_thread_run:18978: exiting
*** 1608147558.376732000 123145366228992 master_thread_run:19203: exiting

I opened an upstream civetweb/civetweb#952 with the same patch as well.

Thanks,
Gregor

@JackBoosY
Copy link
Copy Markdown
Contributor

JackBoosY commented Dec 17, 2020

Waiting for the official reply.

@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Dec 17, 2020
@gjasny
Copy link
Copy Markdown
Contributor Author

gjasny commented Dec 17, 2020

Merged upstream.

@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 18, 2020
@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 18, 2020

Thanks for submitting this fix here and also upstream! :D

@BillyONeal BillyONeal merged commit 66bac12 into microsoft:master Dec 18, 2020
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@gjasny
[civetweb] Disable extensive log output for debug builds (microsoft#1…
5ce695e 
…5168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gjasny @JackBoosY @BillyONeal