[comms] fixes debug build configuration#15159
Merged
vicroms merged 14 commits intomicrosoft:masterfrom Dec 18, 2020
mathisloge:comms-fix
Merged
[comms] fixes debug build configuration#15159vicroms merged 14 commits intomicrosoft:masterfrom mathisloge:comms-fix
vicroms merged 14 commits intomicrosoft:masterfrom
mathisloge:comms-fix
Conversation
Contributor
Author
Member
|
Please update the port version of all updated ports. |
vicroms
requested changes
Dec 16, 2020
Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
vicroms
reviewed
Dec 16, 2020
JackBoosY
suggested changes
Dec 17, 2020
JackBoosY
approved these changes
Dec 18, 2020
Contributor
|
LGTM. |
vicroms
approved these changes
Dec 18, 2020
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Dec 18, 2020
[comms] fixes debug build configuration (microsoft#15159)
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
* set include directory correctly * Revert "set include directory correctly" This reverts commit bde9f29. * try suggested fix * try changes * apply fix for comms-ublox * fix commsdsl * try moving in port dir * Revert "try moving in port dir" This reverts commit 93546df. * set port version * fix port version Co-authored-by: Victor Romero <romerosanchezv@gmail.com> * add usage file to comms * add line to usage Co-authored-by: Victor Romero <romerosanchezv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
i've discoverd that the debug build configuration is broken as soon as one is including the project.
this PR moves the cmake files from lib / debug/lib to share. the root cause was that the target config cmake file had INTERFACE_INCLUDE_DIRECTORIES set to debug/include/{port}
Which triplets are supported/not supported? Have you updated the CI baseline? uwp /yes
Does your PR follow the maintainer guide?yes