Skip to content

[vcpkg ci] upload diff from clang-format to artifacts#15141

Merged
strega-nil merged 20 commits intomicrosoft:masterfrom
strega-nil:upload-format-diff
Dec 16, 2020
Merged

[vcpkg ci] upload diff from clang-format to artifacts#15141
strega-nil merged 20 commits intomicrosoft:masterfrom
strega-nil:upload-format-diff

Conversation

@strega-nil
Copy link
Copy Markdown
Contributor

this allows people who do not have access to clang-format to format their code via diff

this allows people who do not have access to clang-format to format their code via diff
@strega-nil
Copy link
Copy Markdown
Contributor Author

@BillyONeal this looks good to merge to me as of right now

- stage: check_cxx_formatting
displayName: 'Check the formatting of the C++'
- stage: FormatChecks
displayName: 'Formatting and Documentation Checks'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either this one should have a colon or the one below on 52 should not

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for that is:

image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Dec 16, 2020
@strega-nil strega-nil merged commit 3076717 into microsoft:master Dec 16, 2020
@strega-nil strega-nil deleted the upload-format-diff branch December 16, 2020 21:14
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
* [vcpkg ci] upload diff from clang-format to artifacts

this allows people who do not have access to clang-format to format their code via diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants