[boost-modular-build-helper] Specify msvc version in user-config.jam#15137
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Dec 16, 2020
Merged
Conversation
BillyONeal
reviewed
Dec 15, 2020
| Source: boost-modular-build-helper | ||
| Version: 1.74.0 | ||
| Port-Version: 1 | ||
| Port-Version: 2 |
Member
There was a problem hiding this comment.
Does generate-ports.ps1 need to be updated?
Contributor
There was a problem hiding this comment.
I don't think we need to update in generate-ports.ps1 since when we update the boost to new version, the Port-version would be removed or set to 0.
BillyONeal
approved these changes
Dec 15, 2020
PhoebeHui
approved these changes
Dec 16, 2020
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with generated user-config.jam files for non-system-wide copies of MSVC. If the version of MSVC is not specified, boost-build assumes an extremely old version and fails to build.