Skip to content

[coin] x64-windows-statid-md fixes#15125

Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom
ankurvdev:ankurv/coin
Dec 17, 2020
Merged

[coin] x64-windows-statid-md fixes#15125
BillyONeal merged 3 commits intomicrosoft:masterfrom
ankurvdev:ankurv/coin

Conversation

@ankurvdev
Copy link
Copy Markdown
Contributor

Fix the coin port to build with x64-windows-static-md

  • What does your PR fix? Fixes #

  • Which triplets are supported/not supported? Have you updated the CI baseline?

  • Does your PR follow the maintainer guide?

@JonLiu1993 JonLiu1993 added the category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. label Dec 15, 2020
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.

@ankurvdev ankurvdev requested a review from JackBoosY December 15, 2020 20:56
@ankurvdev
Copy link
Copy Markdown
Contributor Author

Please bump the port version. See documentation.

Done. Please review and merge

@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. category:port-bug The issue is with a library, which is something the port should already support and removed requires:author-response labels Dec 16, 2020
@BillyONeal BillyONeal merged commit 43ed421 into microsoft:master Dec 17, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your contribution!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
@ankurvdev ankurvdev deleted the ankurv/coin branch December 25, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:community-triplet A PR or issue related to community triplets not officially validated by the vcpkg team. category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants