Skip to content

[vcpkg] VCPKG_ENV_PASSTHROUGH_UNTRACKED#15115

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
ras0219:dev/roschuma/passthrough-untracked
Dec 17, 2020
Merged

[vcpkg] VCPKG_ENV_PASSTHROUGH_UNTRACKED#15115
ras0219-msft merged 2 commits intomicrosoft:masterfrom
ras0219:dev/roschuma/passthrough-untracked

Conversation

@ras0219
Copy link
Copy Markdown
Contributor

@ras0219 ras0219 commented Dec 15, 2020

This PR adds a new triplet setting VCPKG_ENV_PASSTHROUGH_UNTRACKED, similar to the existing VCPKG_ENV_PASSTHROUGH. This new setting will allow the specified environment variables into the port evaluation without including them in the resulting package ABI.

As an example, the user may want to pass through something like EMSCRIPTEN_SDK_ROOT or ANDROID_SDK_ROOT; compiler tracking will still ensure different sdks result in different packages and passing these through UNTRACKED prevents different machine paths from preventing binary reuse.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal labels Dec 15, 2020
@ras0219 ras0219 force-pushed the dev/roschuma/passthrough-untracked branch from 57ed898 to 83eae5c Compare December 15, 2020 18:30
@ras0219 ras0219 marked this pull request as ready for review December 15, 2020 18:34
@ras0219 ras0219 changed the title [vcpkg] [WIP] VCPKG_ENV_PASSTHROUGH_UNTRACKED [vcpkg] VCPKG_ENV_PASSTHROUGH_UNTRACKED Dec 15, 2020
@ras0219-msft ras0219-msft merged commit 9a81392 into microsoft:master Dec 17, 2020
@ras0219 ras0219 deleted the dev/roschuma/passthrough-untracked branch December 18, 2020 01:21
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
* [vcpkg] Add VCPKG_ENV_PASSTHROUGH_UNTRACKED

* [vcpkg] CR comments

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
* [vcpkg] Add VCPKG_ENV_PASSTHROUGH_UNTRACKED

* [vcpkg] CR comments

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants