[freetype] avoid target_link_libraries call since qt6 does not like it.#15112
Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom Dec 18, 2020
Merged
[freetype] avoid target_link_libraries call since qt6 does not like it.#15112BillyONeal merged 2 commits intomicrosoft:masterfrom
BillyONeal merged 2 commits intomicrosoft:masterfrom
Conversation
JackBoosY
approved these changes
Dec 15, 2020
Member
|
Stupid question: Why is the right fix here not linking with |
Contributor
Author
|
Because it is unofficial and might not be available in custom FindBrotli.cmake. As such linking the libraries directly is the only correct way unless there is a official cmake or upstream target which could be forced across all downstream ports. |
Member
|
Sounds good! |
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for some reason qt6 does not like the target_link_libraries call so use the set_property approach