Skip to content

[vcpkg] Fix CMAKE_CURRENT_LIST_DIR in load_dep_info_vars()#15110

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
ras0219:dev/roschuma/deps-current-dir
Dec 15, 2020
Merged

[vcpkg] Fix CMAKE_CURRENT_LIST_DIR in load_dep_info_vars()#15110
ras0219-msft merged 1 commit intomicrosoft:masterfrom
ras0219:dev/roschuma/deps-current-dir

Conversation

@ras0219
Copy link
Copy Markdown
Contributor

@ras0219 ras0219 commented Dec 14, 2020

#14661 fixed CMAKE_CURRENT_LIST_DIR for tags but not for dep_info_vars. This PR extracts the common sequence to fix the issue for both.

@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:internal labels Dec 15, 2020
@JackBoosY JackBoosY requested a review from BillyONeal December 15, 2020 02:33
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 15, 2020
@ras0219-msft ras0219-msft merged commit ef7e1ab into microsoft:master Dec 15, 2020
@ras0219-msft
Copy link
Copy Markdown
Contributor

Thanks for the quick review!

@ras0219 ras0219 deleted the dev/roschuma/deps-current-dir branch December 15, 2020 18:27
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
…#15110)

Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants