Skip to content

Properly index package actions in log#15076

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
gritukan:master
Dec 15, 2020
Merged

Properly index package actions in log#15076
BillyONeal merged 2 commits intomicrosoft:masterfrom
gritukan:master

Conversation

@gritukan
Copy link
Copy Markdown
Contributor

Describe the pull request

  • What does your PR fix?

When running vcpkg install with some packages already installed, invalid message of type Starting package 3/2: opencl:x64-linux may occur. It happens because results vector might contain already installed actions, while they are not counted in the total number of actions.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Tested myself on x64-linux.

Yes.

@JackBoosY JackBoosY added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Dec 14, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 14, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Probably fixes #13130

@BillyONeal BillyONeal merged commit 2aaa675 into microsoft:master Dec 15, 2020
@BillyONeal
Copy link
Copy Markdown
Member

Thanks for your help!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 15, 2020
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants