[vcpkg registries] Add git registries by strega-nil · Pull Request #15054 · microsoft/vcpkg

strega-nil · 2020-12-11T00:02:05Z

Add git registries support to the registries module of vcpkg.

Depends on #15583

ras0219

(only reviewed to registries.cpp:193)

This will need a lot of tests added before merging; it should probably pull #15081 to make that easier. I suspect it will be faster to review and merge this PR if it was split into two:

Refactor existing Builtin+Filesystem registry into this new architecture (+tests for those)
Adding Git registries + tests

(Remember that code review costs are super-linear with number of lines changed!)

toolsrc/src/vcpkg/configuration.cpp

toolsrc/src/vcpkg/portfileprovider.cpp

toolsrc/src/vcpkg/registries.cpp

toolsrc/include/vcpkg/versiondeserializers.h

toolsrc/src/vcpkg/vcpkgpaths.cpp

Issues solved.

strega-nil

I didn't notice anything else in a cursory glance.

scripts/e2e_ports/port_versions/baseline.json

ras0219

This also needs several end-to-end tests. I'd suggest having the end-to-end tests construct a local git repo with an appropriate history and then point to that temporary repo for testing.

toolsrc/src/vcpkg/base/system.process.cpp

toolsrc/src/vcpkg/commands.porthistory.cpp

toolsrc/include/vcpkg/base/system.process.h

toolsrc/src/vcpkg/registries.cpp

strega-nil · 2021-01-11T03:56:19Z

This also needs several end-to-end tests. I'd suggest having the end-to-end tests construct a local git repo with an appropriate history and then point to that temporary repo for testing.

It does, though? https://github.com/microsoft/vcpkg/pull/15054/files#diff-de6d1117ad4379767b02529167248f18bbad1b56758118cccfaa915d534be7b7R56

ras0219 · 2021-01-11T18:06:18Z

Oops, I managed to forget about the e2e tests by the time I got to the end of the diff 👍

scripts/azure-pipelines/end-to-end-tests-dir/registries.ps1

scripts/buildsystems/vcpkg.cmake

scripts/azure-pipelines/end-to-end-tests-dir/registries.ps1

scripts/azure-pipelines/end-to-end-tests-prelude.ps1

toolsrc/include/vcpkg/base/unique_resource.h

toolsrc/src/vcpkg/vcpkgpaths.cpp

toolsrc/src/vcpkg/registries.cpp

* Add git registries support to the registries module of vcpkg. * add e2e tests for git registries * fix vcpkg.cmake for registries

strega-nil · 2021-01-14T23:58:57Z

/azp run

azure-pipelines · 2021-01-14T23:59:10Z

Azure Pipelines successfully started running 1 pipeline(s).

[vcpkg registries] Add git registries (microsoft#15054)

* [vcpkg registries] Add git registries support * Add git registries support to the registries module of vcpkg. * add e2e tests for git registries * fix vcpkg.cmake for registries * fix CRs, remove a thing * better error messages * Billy CRs * fix Robert's CR comment * I learned about `-c` today * format * fix baseline.json * failing to find baseline is technically not a bug

strega-nil requested review from ras0219-msft and vicroms December 11, 2020 00:02

strega-nil force-pushed the git-registries-impl branch from f56455e to d8b7c76 Compare December 11, 2020 00:11

JonLiu1993 assigned PhoebeHui Dec 11, 2020

PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Dec 11, 2020

strega-nil marked this pull request as ready for review December 12, 2020 00:49

ras0219 suggested changes Dec 14, 2020

View reviewed changes

strega-nil mentioned this pull request Dec 14, 2020

[vcpkg registries] support versions #15114

Merged

strega-nil force-pushed the git-registries-impl branch from ecf06e3 to 5907e84 Compare December 14, 2020 22:54

strega-nil marked this pull request as draft December 14, 2020 22:54

strega-nil added the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 14, 2020

strega-nil changed the title ~~[vcpkg registries] Registries: Take 2 (allow registries + versioning)~~ [vcpkg registries] Add git registries Dec 14, 2020

vicroms reviewed Dec 15, 2020

View reviewed changes

toolsrc/include/vcpkg/versiondeserializers.h Outdated Show resolved Hide resolved

vicroms added the info:internal label Dec 18, 2020

strega-nil force-pushed the git-registries-impl branch 5 times, most recently from a460826 to 0a9b960 Compare December 21, 2020 23:41

strega-nil removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Dec 21, 2020

strega-nil marked this pull request as ready for review December 21, 2020 23:41

BillyONeal reviewed Dec 22, 2020

View reviewed changes

vicroms previously requested changes Dec 23, 2020

View reviewed changes

toolsrc/src/vcpkg/vcpkgpaths.cpp Outdated Show resolved Hide resolved

toolsrc/src/vcpkg/vcpkgpaths.cpp Outdated Show resolved Hide resolved

strega-nil requested review from BillyONeal and vicroms January 7, 2021 21:29

strega-nil commented Jan 8, 2021

View reviewed changes

scripts/e2e_ports/port_versions/baseline.json Outdated Show resolved Hide resolved

ras0219 suggested changes Jan 9, 2021

View reviewed changes

strega-nil mentioned this pull request Jan 11, 2021

[vcpkg] Add a different way to use CommandBuilder, support InWorkingDirectory #15583

Merged

ras0219 reviewed Jan 11, 2021

View reviewed changes

strega-nil marked this pull request as draft January 11, 2021 19:04

strega-nil added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jan 11, 2021

strega-nil force-pushed the git-registries-impl branch 2 times, most recently from 248acec to 98f90a7 Compare January 12, 2021 17:44

strega-nil marked this pull request as ready for review January 12, 2021 17:50

strega-nil force-pushed the git-registries-impl branch from fe452d3 to 3fa0e5f Compare January 13, 2021 18:44

BillyONeal reviewed Jan 13, 2021

View reviewed changes

strega-nil force-pushed the git-registries-impl branch 2 times, most recently from b92308f to 9e00cc6 Compare January 14, 2021 00:53

strega-nil added 5 commits January 14, 2021 14:03

[vcpkg registries] Add git registries support

f8d6c1c

* Add git registries support to the registries module of vcpkg. * add e2e tests for git registries * fix vcpkg.cmake for registries

fix CRs, remove a thing

8a9951f

better error messages

7ad514e

Billy CRs

f73aa64

fix Robert's CR comment

0052b57

strega-nil force-pushed the git-registries-impl branch from b7642a1 to 0052b57 Compare January 14, 2021 22:04

strega-nil added 2 commits January 14, 2021 14:15

I learned about -c today

08862a9

format

8b7e0f1

ras0219 approved these changes Jan 14, 2021

View reviewed changes

strega-nil added 2 commits January 14, 2021 15:23

fix baseline.json

71883bf

failing to find baseline is technically not a bug

bceebe2

strega-nil merged commit a597134 into microsoft:master Jan 15, 2021

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jan 15, 2021

Merge pull request #491 from microsoft/master

1de2248

[vcpkg registries] Add git registries (microsoft#15054)

strega-nil deleted the git-registries-impl branch January 19, 2021 19:51

Conversation

strega-nil commented Dec 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ras0219 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ras0219 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil commented Jan 11, 2021

Uh oh!

ras0219 commented Jan 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

strega-nil commented Jan 14, 2021

Uh oh!

azure-pipelines bot commented Jan 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

strega-nil commented Dec 11, 2020 •

edited

Loading