[vcpkg] Don't require native tools on arm64 macOS#15045
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom Dec 12, 2020
Merged
[vcpkg] Don't require native tools on arm64 macOS#15045BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
ras0219-msft
approved these changes
Dec 10, 2020
Contributor
ras0219-msft
left a comment
There was a problem hiding this comment.
LGTM assuming apple silicon can run x64 binaries directly
Member
|
Thanks! |
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been building on macOS (Apple Silicon) and vcpkg has started saying:
"Environment variable VCPKG_FORCE_SYSTEM_BINARIES must be set on arm and s390x platforms."
I assume it's now being built as native code instead of x86_64 - however, I see no reason that we need to use system binaries on Apple Silicon. We can still run x86_64 binaries of cmake, etc.
As such I propose this patch to exclude macOS from this error, in the same way Windows is excluded.