[clrng] Add new port: clRNG#14876
Merged
BillyONeal merged 22 commits intomicrosoft:masterfrom Dec 17, 2020
Merged
Conversation
NancyLi1013
suggested changes
Dec 2, 2020
MathiasMagnus
commented
Dec 8, 2020
Contributor
Author
MathiasMagnus
left a comment
There was a problem hiding this comment.
@NancyLi1013 I think I addressed all your comments in beneficial ways. Please review again.
NancyLi1013
suggested changes
Dec 9, 2020
fix version format. Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
Contributor
Author
|
@NancyLi1013 All tests pass, two open conversations remaining, one an open question (on my part) and one which I may be closed. |
NancyLi1013
suggested changes
Dec 15, 2020
NancyLi1013
approved these changes
Dec 16, 2020
Contributor
|
LGTM now, thanks for your PR @MathiasMagnus. |
Member
|
Thanks again! |
ryukw7
pushed a commit
to ryukw7/vcpkg
that referenced
this pull request
Dec 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR adds a new port to supplement the existing clBLAS and clFFT ports, another member of the clMathLibraries: clRNG
What does your PR fix? Fixes #
Nothing.
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-windows, x64-windows-static, x64-linux tested
I had to disable arm builds of the package, as the headers are hardcoded to fail. I do not have the bandwidth to test and add proper ARM support.
Does your PR follow the maintainer guide?
I think it does.