Skip to content

[ceres] upgrade to 2.0.0#14719

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
fran6co:ceres_2
Dec 1, 2020
Merged

[ceres] upgrade to 2.0.0#14719
strega-nil merged 1 commit intomicrosoft:masterfrom
fran6co:ceres_2

Conversation

@fran6co
Copy link
Copy Markdown
Contributor

@fran6co fran6co commented Nov 23, 2020

No description provided.

@NancyLi1013 NancyLi1013 self-assigned this Nov 23, 2020
@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Nov 23, 2020
@fran6co
Copy link
Copy Markdown
Contributor Author

fran6co commented Nov 23, 2020

Theia needs to be fixed upstream to support ceres 2.0.0

NancyLi1013
NancyLi1013 suggested changes Nov 24, 2020
View reviewed changes
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Nov 24, 2020

The failures for theia on Linux:

/mnt/vcpkg-ci/installed/x64-linux/include/ceres/internal/integer_sequence_algorithm.h:64:21: error: ‘integer_sequence’ is not a member of ‘std’
 struct SumImpl<std::integer_sequence<T, N, Ns...>> {
                     ^~~~~~~~~~~~~~~~
/mnt/vcpkg-ci/installed/x64-linux/include/ceres/internal/integer_sequence_algorithm.h:64:21: error: ‘integer_sequence’ is not a member of ‘std’
/mnt/vcpkg-ci/installed/x64-linux/include/ceres/internal/integer_sequence_algorithm.h:64:46: error: wrong number of template arguments (3, should be 1)
 struct SumImpl<std::integer_sequence<T, N, Ns...>> {
                                              ^~~

Related issue from upstream ceres-solver/ceres-solver#604

Needs to use C++ standard >= 14 to build.

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Nov 27, 2020

Seems it doesn't work.

========== Warning: Compiling with Debug mode ==========
-- CMAKE_CXX_FLAGS: -fPIC -std=c++11
-- Found Eigen version 3.3.7: /mnt/vcpkg-ci/installed/x64-linux/include/eigen3
-- CMAKE_CXX_FLAGS: -fPIC -std=c++11

@fran6co
Copy link
Copy Markdown
Contributor Author

fran6co commented Nov 27, 2020

Seems it doesn't work.

========== Warning: Compiling with Debug mode ==========
-- CMAKE_CXX_FLAGS: -fPIC -std=c++11
-- Found Eigen version 3.3.7: /mnt/vcpkg-ci/installed/x64-linux/include/eigen3
-- CMAKE_CXX_FLAGS: -fPIC -std=c++11

@NancyLi1013 fixed now

@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 1, 2020

@fran6co

Have you test these features? Can they work fine?

@fran6co
Copy link
Copy Markdown
Contributor Author

fran6co commented Dec 1, 2020 via email

@NancyLi1013 NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:all-feature-testing labels Dec 1, 2020
@NancyLi1013
Copy link
Copy Markdown
Contributor

NancyLi1013 commented Dec 1, 2020

LGTM now, thanks for your PR @fran6co.

@strega-nil strega-nil merged commit 326e8c8 into microsoft:master Dec 1, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

strega-nil commented Dec 1, 2020

Cool, thanks @fran6co :)

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 7, 2020

In CI we're seeing failures to build ceres probably resulting from this change:

cmd.exe /C "cd . && D:\downloads\tools\cmake-3.18.4-windows\cmake-3.18.4-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=internal\ceres\CMakeFiles\schur_eliminator_benchmark.dir --rc="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\link.exe"  internal\ceres\CMakeFiles\schur_eliminator_benchmark.dir\schur_eliminator_benchmark.cc.obj  /out:bin\schur_eliminator_benchmark.exe /implib:lib\schur_eliminator_benchmark.lib /pdb:bin\schur_eliminator_benchmark.pdb /version:0.0 /machine:X86 /ignore:4049 /nologo    /debug /INCREMENTAL /subsystem:console  lib\ceres-debug.lib  D:\installed\x86-windows\debug\lib\benchmark.lib  D:\installed\x86-windows\debug\lib\glog.lib  D:\installed\x86-windows\debug\lib\gflags_debug.lib  shlwapi.lib  shlwapi.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK Pass 1: command "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\link.exe internal\ceres\CMakeFiles\schur_eliminator_benchmark.dir\schur_eliminator_benchmark.cc.obj /out:bin\schur_eliminator_benchmark.exe /implib:lib\schur_eliminator_benchmark.lib /pdb:bin\schur_eliminator_benchmark.pdb /version:0.0 /machine:X86 /ignore:4049 /nologo /debug /INCREMENTAL /subsystem:console lib\ceres-debug.lib D:\installed\x86-windows\debug\lib\benchmark.lib D:\installed\x86-windows\debug\lib\glog.lib D:\installed\x86-windows\debug\lib\gflags_debug.lib shlwapi.lib shlwapi.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:internal\ceres\CMakeFiles\schur_eliminator_benchmark.dir/intermediate.manifest internal\ceres\CMakeFiles\schur_eliminator_benchmark.dir/manifest.res" failed (exit code 1120) with the following output:
schur_eliminator_benchmark.cc.obj : error LNK2019: unresolved external symbol "public: __thiscall ceres::internal::BlockRandomAccessDenseMatrix::BlockRandomAccessDenseMatrix(class std::vector<int,class std::allocator<int> > const &)" (??0BlockRandomAccessDenseMatrix@internal@ceres@@QAE@ABV?$vector@HV?$allocator@H@std@@@std@@@Z) referenced in function "public: __thiscall ceres::internal::BenchmarkData::BenchmarkData(int)" (??0BenchmarkData@internal@ceres@@QAE@H@Z)
schur_eliminator_benchmark.cc.obj : error LNK2019: unresolved external symbol "public: __thiscall ceres::internal::BlockSparseMatrix::BlockSparseMatrix(struct ceres::internal::CompressedRowBlockStructure *)" (??0BlockSparseMatrix@internal@ceres@@QAE@PAUCompressedRowBlockStructure@12@@Z) referenced in function "public: __thiscall ceres::internal::BenchmarkData::BenchmarkData(int)" (??0BenchmarkData@internal@ceres@@QAE@H@Z)
schur_eliminator_benchmark.cc.obj : error LNK2019: unresolved external symbol "public: struct ceres::internal::CompressedRowBlockStructure const * __thiscall ceres::internal::BlockSparseMatrix::block_structure(void)const " (?block_structure@BlockSparseMatrix@internal@ceres@@QBEPBUCompressedRowBlockStructure@23@XZ) referenced in function "void __cdecl ceres::internal::BM_SchurEliminatorEliminate(class benchmark::State &)" (?BM_SchurEliminatorEliminate@internal@ceres@@YAXAAVState@benchmark@@@Z)
schur_eliminator_benchmark.cc.obj : error LNK2019: unresolved external symbol "public: __thiscall ceres::internal::ThreadPool::ThreadPool(void)" (??0ThreadPool@internal@ceres@@QAE@XZ) referenced in function "public: __thiscall ceres::internal::ContextImpl::ContextImpl(void)" (??0ContextImpl@internal@ceres@@QAE@XZ)
schur_eliminator_benchmark.cc.obj : error LNK2019: unresolved external symbol "public: __thiscall ceres::internal::ThreadPool::~ThreadPool(void)" (??1ThreadPool@internal@ceres@@QAE@XZ) referenced in function "public: virtual __thiscall ceres::internal::ContextImpl::~ContextImpl(void)" (??1ContextImpl@internal@ceres@@UAE@XZ)
schur_eliminator_benchmark.cc.obj : error LNK2019: unresolved external symbol "public: static class ceres::internal::SchurEliminatorBase * __cdecl ceres::internal::SchurEliminatorBase::Create(struct ceres::internal::LinearSolver::Options const &)" (?Create@SchurEliminatorBase@internal@ceres@@SAPAV123@ABUOptions@LinearSolver@23@@Z) referenced in function "void __cdecl ceres::internal::BM_SchurEliminatorEliminate(class benchmark::State &)" (?BM_SchurEliminatorEliminate@internal@ceres@@YAXAAVState@benchmark@@@Z)
bin\schur_eliminator_benchmark.exe : fatal error LNK1120: 6 unresolved externals
[156/162] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.18.4-windows\cmake-3.18.4-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=internal\ceres\CMakeFiles\small_blas_gemv_benchmark.dir --rc="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\link.exe"  internal\ceres\CMakeFiles\small_blas_gemv_benchmark.dir\small_blas_gemv_benchmark.cc.obj  /out:bin\small_blas_gemv_benchmark.exe /implib:lib\small_blas_gemv_benchmark.lib /pdb:bin\small_blas_gemv_benchmark.pdb /version:0.0 /machine:X86 /ignore:4049 /nologo    /debug /INCREMENTAL /subsystem:console  lib\ceres-debug.lib  D:\installed\x86-windows\debug\lib\benchmark.lib  D:\installed\x86-windows\debug\lib\glog.lib  D:\installed\x86-windows\debug\lib\gflags_debug.lib  shlwapi.lib  shlwapi.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
[157/162] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.18.4-windows\cmake-3.18.4-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=internal\ceres\CMakeFiles\small_blas_gemm_benchmark.dir --rc="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\link.exe"  internal\ceres\CMakeFiles\small_blas_gemm_benchmark.dir\small_blas_gemm_benchmark.cc.obj  /out:bin\small_blas_gemm_benchmark.exe /implib:lib\small_blas_gemm_benchmark.lib /pdb:bin\small_blas_gemm_benchmark.pdb /version:0.0 /machine:X86 /ignore:4049 /nologo    /debug /INCREMENTAL /subsystem:console  lib\ceres-debug.lib  D:\installed\x86-windows\debug\lib\benchmark.lib  D:\installed\x86-windows\debug\lib\glog.lib  D:\installed\x86-windows\debug\lib\gflags_debug.lib  shlwapi.lib  shlwapi.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
[158/162] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.18.4-windows\cmake-3.18.4-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=internal\ceres\autodiff_benchmarks\CMakeFiles\autodiff_benchmarks.dir --rc="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\link.exe"  internal\ceres\autodiff_benchmarks\CMakeFiles\autodiff_benchmarks.dir\autodiff_benchmarks.cc.obj  /out:bin\autodiff_benchmarks.exe /implib:lib\autodiff_benchmarks.lib /pdb:bin\autodiff_benchmarks.pdb /version:0.0 /machine:X86 /ignore:4049 /nologo    /debug /INCREMENTAL /subsystem:console  lib\ceres-debug.lib  D:\installed\x86-windows\debug\lib\benchmark.lib  D:\installed\x86-windows\debug\lib\glog.lib  D:\installed\x86-windows\debug\lib\gflags_debug.lib  shlwapi.lib  shlwapi.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
   Creating library lib\autodiff_benchmarks.lib and object lib\autodiff_benchmarks.exp
   Creating library lib\autodiff_benchmarks.lib and object lib\autodiff_benchmarks.exp
[159/162] cmd.exe /C "cd . && D:\downloads\tools\cmake-3.18.4-windows\cmake-3.18.4-win32-x86\bin\cmake.exe -E vs_link_exe --intdir=internal\ceres\autodiff_benchmarks\CMakeFiles\autodiff_benchmarks_fast_math.dir --rc="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\PROGRA~2\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\link.exe"  internal\ceres\autodiff_benchmarks\CMakeFiles\autodiff_benchmarks_fast_math.dir\autodiff_benchmarks.cc.obj  /out:bin\autodiff_benchmarks_fast_math.exe /implib:lib\autodiff_benchmarks_fast_math.lib /pdb:bin\autodiff_benchmarks_fast_math.pdb /version:0.0 /machine:X86 /ignore:4049 /nologo    /debug /INCREMENTAL /subsystem:console  lib\ceres-debug.lib  D:\installed\x86-windows\debug\lib\benchmark.lib  D:\installed\x86-windows\debug\lib\glog.lib  D:\installed\x86-windows\debug\lib\gflags_debug.lib  shlwapi.lib  shlwapi.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
   Creating library lib\autodiff_benchmarks_fast_math.lib and object lib\autodiff_benchmarks_fast_math.exp
   Creating library lib\autodiff_benchmarks_fast_math.lib and object lib\autodiff_benchmarks_fast_math.exp
[160/162] "C:\PROGRA~2\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x86\cl.exe"   /TP -DCERES_BUILDING_SHARED_LIBRARY -DCERES_SUITESPARSE_VERSION=\"\" -DEIGEN_MPL2_ONLY -DGFLAGS_IS_A_DLL=1 -DGLOG_NO_ABBREVIATED_SEVERITIES -DGOOGLE_GLOG_DLL_DECL=__declspec(dllimport) -DGOOGLE_GLOG_DLL_DECL_FOR_UNITTESTS=__declspec(dllimport) -D_USE_MATH_DEFINES -D_VARIADIC_MAX=10 -ID:\buildtrees\ceres\src\2.0.0-e041eed1b2.clean\internal -ID:\buildtrees\ceres\src\2.0.0-e041eed1b2.clean\internal\ceres -Iconfig -ID:\buildtrees\ceres\src\2.0.0-e041eed1b2.clean\include -ID:\installed\x86-windows\include -ID:\installed\x86-windows\share\eigen3\..\..\include\eigen3 /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP  /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1  /wd4018 /wd4267 /wd4099 /wd4996 /wd4800 /wd4244 /wd4251 /bigobj -std:c++14 /showIncludes /Fointernal\ceres\CMakeFiles\invert_psd_matrix_benchmark.dir\invert_psd_matrix_benchmark.cc.obj /Fdinternal\ceres\CMakeFiles\invert_psd_matrix_benchmark.dir\ /FS -c D:\buildtrees\ceres\src\2.0.0-e041eed1b2.clean\internal\ceres\invert_psd_matrix_benchmark.cc
ninja: build stopped: subcommand failed.

Any ideas what might be going on?

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Dec 7, 2020

I think it's:

if (BUILD_BENCHMARKS)
  find_package(benchmark QUIET)
  if (benchmark_FOUND)
     message("-- Found Google benchmark library. Building Ceres benchmarks.")
  else()
     message("-- Failed to find Google benchmark library, disabling build of benchmarks.")
     update_cache_variable(BUILD_BENCHMARKS OFF)
  endif()
  mark_as_advanced(benchmark_DIR)
endif()

and something being wrong with the benchmarks target. For now I'm going to pass -DBUILD_BENCHMARKS=OFF

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Dec 7, 2020
@BillyONeal
2020-12-07 Build Fixes
689e6c9 
From most recent completed nightly build:
https://dev.azure.com/vcpkg/public/_build/results?buildId=46182

PASSING, REMOVE FROM FAIL LIST: ignition-msgs5:x64-linux (.\scripts\ci.baseline.txt)

I'm assuming this got fixed by @strega-nil 's llvm changes: microsoft#14399

PASSING, REMOVE FROM FAIL LIST: libraqm:x64-windows-static (.\scripts\ci.baseline.txt)

Cause unknown.

PASSING, REMOVE FROM FAIL LIST: openssl-windows:arm-uwp (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: openssl-windows:x64-uwp (.\scripts\ci.baseline.txt)

Probably fixed by microsoft#14308 ; also removed Supports: excluded entries for these.

PASSING, REMOVE FROM FAIL LIST: speexdsp:x64-osx (.\scripts\ci.baseline.txt)

Probably fixed by microsoft#14758

PASSING, REMOVE FROM FAIL LIST: sundials:arm64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: sundials:x64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: sundials:x86-windows (.\scripts\ci.baseline.txt)

Probably fixed by microsoft#14618

PASSING, REMOVE FROM FAIL LIST: wepoll:arm-uwp (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: wepoll:x64-uwp (.\scripts\ci.baseline.txt)

Probably fixed by microsoft#14456 -- and also fixed missing Supports.

REGRESSION: ceres:x64-windows. If expected, add ceres:x64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: ceres:x86-windows. If expected, add ceres:x86-windows=fail to .\scripts\ci.baseline.txt.

Probably broken by microsoft#14719 ; ceres has:

```
if (BUILD_BENCHMARKS)
  find_package(benchmark QUIET)
  if (benchmark_FOUND)
     message("-- Found Google benchmark library. Building Ceres benchmarks.")
  else()
     message("-- Failed to find Google benchmark library, disabling build of benchmarks.")
     update_cache_variable(BUILD_BENCHMARKS OFF)
  endif()
  mark_as_advanced(benchmark_DIR)
endif()
```

so it passed there because Google Benchmark was not also installed. Worked around by `-DBUILD_BENCHMARKS=OFF`.

REGRESSION: dirent:arm64-windows. If expected, add dirent:arm64-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Downloading https://github.com/tronkko/dirent/archive/1.23.2.tar.gz...
-- Downloading https://github.com/tronkko/dirent/archive/1.23.2.tar.gz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):
```

REGRESSION: discord-rpc:arm64-windows. If expected, add discord-rpc:arm64-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Downloading https://github.com/discordapp/discord-rpc/archive/v3.4.0.tar.gz...
-- Downloading https://github.com/discordapp/discord-rpc/archive/v3.4.0.tar.gz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):
```

REGRESSION: libunibreak:x86-windows. If expected, add libunibreak:x86-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Note: libunibreak only supports static library linkage. Building static library.
-- Downloading https://github.com/adah1972/libunibreak/archive/8df6ef4ebe5dbd2a49539d05366337ab7fb57ae3.tar.gz...
-- Downloading https://github.com/adah1972/libunibreak/archive/8df6ef4ebe5dbd2a49539d05366337ab7fb57ae3.tar.gz... Failed. Status: 28;"Timeout was reached"
```

REGRESSION: libzip:x86-windows. If expected, add libzip:x86-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Downloading https://github.com/nih-at/libzip/archive/66e496489bdae81bfda8b0088172871d8fda0032.tar.gz...
-- Downloading https://github.com/nih-at/libzip/archive/66e496489bdae81bfda8b0088172871d8fda0032.tar.gz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):
```

REGRESSION: ocilib:x64-windows-static. If expected, add ocilib:x64-windows-static=fail to .\scripts\ci.baseline.txt.

Probably broken by microsoft#13158 but it passed there:

       (Link target) ->
         chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymCleanup [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]

Looks like it was skipped before that PR because the port conflicts with chromium-base which couldn't have been caught in that PR. Putting it back on ci.baseline.txt.

REGRESSION: osgearth:x64-windows. If expected, add osgearth:x64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: osgearth:x86-windows. If expected, add osgearth:x86-windows=fail to .\scripts\ci.baseline.txt.

Cause unknown. I think we should skip this one in ci.baseline.txt since I've never seen it work OK.

REGRESSION: qt5-tools:x64-windows-static. If expected, add qt5-tools:x64-windows-static=fail to .\scripts\ci.baseline.txt.

Last I heard @ras0219 was investigating this one but that's been a while now. I pinged him again.
@BillyONeal BillyONeal mentioned this pull request Dec 7, 2020
Merged
BillyONeal added a commit that referenced this pull request Dec 7, 2020
@BillyONeal
2020-12-07 Build Fixes (#14986)
4ee7e51 
From most recent completed nightly build:
https://dev.azure.com/vcpkg/public/_build/results?buildId=46182

PASSING, REMOVE FROM FAIL LIST: ignition-msgs5:x64-linux (.\scripts\ci.baseline.txt)

I'm assuming this got fixed by @strega-nil 's llvm changes: #14399

PASSING, REMOVE FROM FAIL LIST: libraqm:x64-windows-static (.\scripts\ci.baseline.txt)

Cause unknown.

PASSING, REMOVE FROM FAIL LIST: openssl-windows:arm-uwp (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: openssl-windows:x64-uwp (.\scripts\ci.baseline.txt)

Probably fixed by #14308 ; also removed Supports: excluded entries for these.

PASSING, REMOVE FROM FAIL LIST: speexdsp:x64-osx (.\scripts\ci.baseline.txt)

Probably fixed by #14758

PASSING, REMOVE FROM FAIL LIST: sundials:arm64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: sundials:x64-windows (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: sundials:x86-windows (.\scripts\ci.baseline.txt)

Probably fixed by #14618

PASSING, REMOVE FROM FAIL LIST: wepoll:arm-uwp (.\scripts\ci.baseline.txt)
PASSING, REMOVE FROM FAIL LIST: wepoll:x64-uwp (.\scripts\ci.baseline.txt)

Probably fixed by #14456 -- and also fixed missing Supports.

REGRESSION: ceres:x64-windows. If expected, add ceres:x64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: ceres:x86-windows. If expected, add ceres:x86-windows=fail to .\scripts\ci.baseline.txt.

Probably broken by #14719 ; ceres has:

```
if (BUILD_BENCHMARKS)
  find_package(benchmark QUIET)
  if (benchmark_FOUND)
     message("-- Found Google benchmark library. Building Ceres benchmarks.")
  else()
     message("-- Failed to find Google benchmark library, disabling build of benchmarks.")
     update_cache_variable(BUILD_BENCHMARKS OFF)
  endif()
  mark_as_advanced(benchmark_DIR)
endif()
```

so it passed there because Google Benchmark was not also installed. Worked around by `-DBUILD_BENCHMARKS=OFF`.

REGRESSION: dirent:arm64-windows. If expected, add dirent:arm64-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Downloading https://github.com/tronkko/dirent/archive/1.23.2.tar.gz...
-- Downloading https://github.com/tronkko/dirent/archive/1.23.2.tar.gz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):
```

REGRESSION: discord-rpc:arm64-windows. If expected, add discord-rpc:arm64-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Downloading https://github.com/discordapp/discord-rpc/archive/v3.4.0.tar.gz...
-- Downloading https://github.com/discordapp/discord-rpc/archive/v3.4.0.tar.gz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):
```

REGRESSION: libunibreak:x86-windows. If expected, add libunibreak:x86-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Note: libunibreak only supports static library linkage. Building static library.
-- Downloading https://github.com/adah1972/libunibreak/archive/8df6ef4ebe5dbd2a49539d05366337ab7fb57ae3.tar.gz...
-- Downloading https://github.com/adah1972/libunibreak/archive/8df6ef4ebe5dbd2a49539d05366337ab7fb57ae3.tar.gz... Failed. Status: 28;"Timeout was reached"
```

REGRESSION: libzip:x86-windows. If expected, add libzip:x86-windows=fail to .\scripts\ci.baseline.txt.

Transient:

```
-- Downloading https://github.com/nih-at/libzip/archive/66e496489bdae81bfda8b0088172871d8fda0032.tar.gz...
-- Downloading https://github.com/nih-at/libzip/archive/66e496489bdae81bfda8b0088172871d8fda0032.tar.gz... Failed. Status: 28;"Timeout was reached"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:184 (message):
```

REGRESSION: ocilib:x64-windows-static. If expected, add ocilib:x64-windows-static=fail to .\scripts\ci.baseline.txt.

Probably broken by #13158 but it passed there:

       (Link target) ->
         chromium_base.lib(stack_trace_win.obj) : error LNK2001: unresolved external symbol __imp_SymCleanup [D:\buildtrees\ocilib\x64-windows-static-rel\4fc7a69e6d-337dbe59ca.clean\proj\dll\ocilib_dll_vs2019.vcxproj]

Looks like it was skipped before that PR because the port conflicts with chromium-base which couldn't have been caught in that PR. Putting it back on ci.baseline.txt.

REGRESSION: osgearth:x64-windows. If expected, add osgearth:x64-windows=fail to .\scripts\ci.baseline.txt.
REGRESSION: osgearth:x86-windows. If expected, add osgearth:x86-windows=fail to .\scripts\ci.baseline.txt.

Cause unknown. I think we should skip this one in ci.baseline.txt since I've never seen it work OK.

REGRESSION: qt5-tools:x64-windows-static. If expected, add qt5-tools:x64-windows-static=fail to .\scripts\ci.baseline.txt.

Last I heard @ras0219 was investigating this one but that's been a while now. I pinged him again.
@BillyONeal BillyONeal mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fran6co @NancyLi1013 @strega-nil @BillyONeal