Skip to content

[lua] Initial addition#128

Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom
adam4813:lua
Oct 7, 2016
Merged

[lua] Initial addition#128
ras0219-msft merged 1 commit intomicrosoft:masterfrom
adam4813:lua

Conversation

@adam4813
Copy link
Copy Markdown
Contributor

@adam4813 adam4813 commented Oct 7, 2016

Adds Lua5.3 resolves #7

@msftclas
Copy link
Copy Markdown

msftclas commented Oct 7, 2016

Hi @adam4813, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@ras0219-msft ras0219-msft merged commit ea65c0e into microsoft:master Oct 7, 2016
ras0219-msft added a commit that referenced this pull request Oct 7, 2016
@ras0219-msft
Copy link
Copy Markdown
Contributor

ras0219-msft commented Oct 7, 2016

Thanks! I made some modifications while merging this in:

  • Added version and description
  • I moved work out of the portfile and into the CMakeLists.txt
  • According to https://www.lua.org/manual/5.3/readme.html, lua.cpp is part of the interpreter and not part of the library so I removed it

@adam4813
Copy link
Copy Markdown
Contributor Author

adam4813 commented Oct 8, 2016

Lua.cpp has an optical command line interpreter, but as far as I know it is needed to prevent a large number of linker errors. I will double check this later today.

@adam4813 adam4813 deleted the lua branch October 9, 2016 21:28
fwcd pushed a commit to fwcd/vcpkg that referenced this pull request Mar 5, 2024
[portmidi] Add overlay with iOS patches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Lua

3 participants