Skip to content

[vcpkg] Fix prettify output not working in some cases#12717

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
Deadpikle:fix/prettify_command
Aug 5, 2020
Merged

[vcpkg] Fix prettify output not working in some cases#12717
strega-nil merged 1 commit intomicrosoft:masterfrom
Deadpikle:fix/prettify_command

Conversation

@Deadpikle
Copy link
Copy Markdown
Contributor

If you changed VCPKG_TARGET_ARCHITECTURE to use x86_64, the prettify command failed to parse things properly. This was found during the changes made for #12657, and this change was done by @strega-nil (thanks!). Relevant conversation in Discord here.

  • What does your PR fix?

No issues closed.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No changes made to triplets/CI.

If you changed VCPKG_TARGET_ARCHITECTURE to use x86_64, the prettify command failed to parse things properly. This was found during the changes made for microsoft#12657 and was completed by @strega-nil (thanks!).
@LilyWangL LilyWangL changed the title Fix prettify output not working in some cases [vcpkg] Fix prettify output not working in some cases Aug 4, 2020
@LilyWangL LilyWangL added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 4, 2020
@LilyWangL LilyWangL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 5, 2020
@strega-nil strega-nil merged commit 2ade390 into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
If you changed VCPKG_TARGET_ARCHITECTURE to use x86_64, the prettify command failed to parse things properly. This was found during the changes made for microsoft#12657 and was completed by @strega-nil (thanks!).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants