Skip to content

[vcpkg] Add VCPKG_TARGET_IS_IOS#12715

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
Deadpikle:feature/target-is-ios
Aug 5, 2020
Merged

[vcpkg] Add VCPKG_TARGET_IS_IOS#12715
strega-nil merged 1 commit intomicrosoft:masterfrom
Deadpikle:feature/target-is-ios

Conversation

@Deadpikle
Copy link
Copy Markdown
Contributor

@Deadpikle Deadpikle commented Aug 3, 2020

There isn't a common definition for when the vcpkg target is iOS. This PR adds one.

This PR is a smaller change pulled from #12657.

  • What does your PR fix?

No bugs closed.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Nothing changed here.

@Deadpikle Deadpikle mentioned this pull request Aug 3, 2020
Closed
@PhoebeHui PhoebeHui self-assigned this Aug 4, 2020
@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 4, 2020
@PhoebeHui PhoebeHui changed the title Add VCPKG_TARGET_IS_IOS [vcpkg] Add VCPKG_TARGET_IS_IOS Aug 4, 2020
PhoebeHui
PhoebeHui approved these changes Aug 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Aug 5, 2020
@strega-nil strega-nil merged commit 7b054d8 into microsoft:master Aug 5, 2020
@Deadpikle Deadpikle deleted the feature/target-is-ios branch August 10, 2020 13:51
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@Deadpikle @hellozee
[vcpkg scripts] Add VCPKG_TARGET_IS_IOS (microsoft#12715)
53fa588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PhoebeHui PhoebeHui

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Deadpikle @PhoebeHui @strega-nil