Skip to content

[argtable3] Update to 3.1.5#12421

Merged
strega-nil merged 4 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/argtable3
Aug 1, 2020
Merged

[argtable3] Update to 3.1.5#12421
strega-nil merged 4 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/argtable3

Conversation

@PhoebeHui
Copy link
Copy Markdown
Contributor

Related to #12297 and argtable/argtable3#32

Update to latest release revision v3.1.5
Remove the patch since it contains the changes in latest source.
Replace the CONTROL file with vcpkg.json.

@PhoebeHui PhoebeHui added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Jul 14, 2020
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 15, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review July 15, 2020 01:40
Copy link
Copy Markdown
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the x86-windows pipeline run:

Warning: an error occurred while parsing 'argtable3'
Use '--debug' to get more information about the parse failures.

@ras0219-msft ras0219-msft marked this pull request as draft July 15, 2020 21:24
@PhoebeHui
Copy link
Copy Markdown
Contributor Author

PhoebeHui commented Jul 16, 2020

@ras0219-msft, thanks for pointing out this! I have updated the json file.

The CI doesn't fail here, that what I concerned.

@BillyONeal @strega-nil, I think the CI should fail when check the json format or start to build the port, could you please have a look?

{
"name": "argtable3",
"version-string": "3.1.5",
"description": "A single-file, ANSI C, command-line parsing library that parses GNU-style command-line options",
"homepage": "www.argtable.org",
}

@NancyLi1013 NancyLi1013 removed the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 17, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review July 23, 2020 01:21
@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 23, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@JackBoosY
Copy link
Copy Markdown
Contributor

rely on #12342

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 31, 2020
@strega-nil strega-nil removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 1, 2020
@strega-nil
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit 337893d into microsoft:master Aug 1, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/argtable3 branch August 11, 2020 01:59
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [argtable3] Update to 3.1.5

* Replace CONTROL file with vcpkg.json

* Remove comma at the end of json file

* Remove bin folder on static build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants