Skip to content

[vcpkg_from_sourceforge] Add retry mirror function (2/2)#12018

Merged
BillyONeal merged 42 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/choose_mirror_in_sourceforge
Jul 3, 2020
Merged

[vcpkg_from_sourceforge] Add retry mirror function (2/2)#12018
BillyONeal merged 42 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/choose_mirror_in_sourceforge

Conversation

@JackBoosY
Copy link
Copy Markdown
Contributor

@JackBoosY JackBoosY commented Jun 19, 2020

When the download fails, try another mirror address.
The download URL follows the following rules:
https://sourceforge.net/projects/${ORG}/files/${REPO}/${REF}/${FILENAME}/download?use_mirror=${MIRROR}

Depends on #11899.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal labels Jun 19, 2020
@c72578
Copy link
Copy Markdown
Contributor

c72578 commented Jun 28, 2020

@JackBoosY Wouldn't it make sense, to try the sourceforge auto-select mirror first (default sourceforge download link of file), and if this fails, try other listed mirrors? Theoretically, auto-select should select a suitable, close mirror. However, this is not always working as we know ...

Download example, trying with auto-select first:

https://sourceforge.net/projects/pcre/files/pcre2/10.35/pcre2-10.35.zip/download
https://sourceforge.net/projects/pcre/files/pcre2/10.35/pcre2-10.35.zip/download?use_mirror=cfhcable
...
https://sourceforge.net/projects/pcre/files/pcre2/10.35/pcre2-10.35.zip/download?use_mirror=netcologne
...

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@c72578 Since the automatic selection of the mirror address is not reliable (this is the main reason for the unstable pipeline state), so I added a manual selection of different mirror addresses in this PR.

@c72578
Copy link
Copy Markdown
Contributor

c72578 commented Jun 28, 2020

@c72578 Since the automatic selection of the mirror address is not reliable (this is the main reason for the unstable pipeline state), so I added a manual selection of different mirror addresses in this PR.

@JackBoosY Yes, that's clear. My point was, to still try the automatic selection first. And if the automatic selection fails, continue with a manual selection of different mirror addresses.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

@c72578 Good suggestion! I will add that after the CI test finished.

@JackBoosY
Copy link
Copy Markdown
Contributor Author

the paraview regression will be solve in other PR.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 28, 2020
@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 30, 2020
@JackBoosY
Copy link
Copy Markdown
Contributor Author

JackBoosY commented Jul 2, 2020

OpenCC regression is due to caching.

@JackBoosY JackBoosY requested a review from BillyONeal July 3, 2020 09:43
@BillyONeal BillyONeal merged commit 21b56d9 into microsoft:master Jul 3, 2020
@JackBoosY JackBoosY deleted the dev/jack/choose_mirror_in_sourceforge branch July 4, 2020 01:07
Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Jul 5, 2020
[vcpkg_from_sourceforge] Add retry mirror function (2/2) (microsoft#12018)
E452003 added a commit to E452003/vcpkg that referenced this pull request Jul 6, 2020
* 'master' of https://github.com/microsoft/vcpkg: (1418 commits)
  [vcpkg integrate] Clean up vcpkg.target file (microsoft#4608)
  [vcpkg_from_sourceforge] Add retry mirror function (2/2) (microsoft#12018)
  [pcre2] Restore the https://ftp.pcre.org/ mirror in addition to the SourceForge mirrors. (microsoft#12233)
  [xercesc] rename feature from xmlch_wchar to xmlch-wchar (microsoft#12205)
  [safeint] Update to 3.24 (microsoft#12217)
  [vcpkg] Remove the tombstones and 'ignore' baseline concepts. (microsoft#12197)
  [msbuild] Revert the importance to Normal (microsoft#12212)
  [vtk] Added opengl feature. (microsoft#11399)
  [span-lite] Update to 0.7.0 (microsoft#12206)
  [cmocka libarchive libiconv libpq libxml2 plibsys] fix drive-by error in vcpkg-cmake-wrappers (microsoft#12196)
  [azure-iot-sdk-c] Fix feature name and enable to build (microsoft#12209)
  [vcpkg] Improve performance of compiler tracking by suppressing aspects of CMake's compiler detection. (microsoft#12203)
  [vcpkg] Remove all uses of Foo::Foo() noexcept = default; to fix microsoft#9955 (microsoft#12201)
  [sqlite3] update to 3.32.3 to deal with security issues (microsoft#12185)
  [infoware] Bump version to 0.5.4 (microsoft#12167)
  [imgui] Update to 1.77 (microsoft#12155)
  [vcpkg] Update message in bootstrap.ps1 (microsoft#12145)
  [vcpkg] Enable NuGet-based binary caching via mono (microsoft#12170)
  Don't change manifest root when manifest isn't enabled. (microsoft#12191)
  Fix sourceparagraph:BooleanField (microsoft#12192)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants