[mlpack] Explicitly depend on stb#11785
Merged
ras0219-msft merged 1 commit intomicrosoft:masterfrom Jun 9, 2020
Merged
Conversation
NancyLi1013
approved these changes
Jun 5, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cenit
pushed a commit
to cenit/vcpkg
that referenced
this pull request
Jun 11, 2020
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
JangBoo
pushed a commit
to JangBoo/vcpkg
that referenced
this pull request
Jun 18, 2020
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlpackinstalls/include/stb_image.hwhen built outside the presence of stb. This PR adds stb as an explicit dependency, ensuring the package does not conflict.As a drive-by fix, this also disables git-based version detection which generates files into the source directory.
Which triplets are supported/not supported? Have you updated the CI baseline?
Yes
Does your PR follow the maintainer guide?
Yes