[vcpkg] Rename the msbuild property VcpkgRoot#11653
Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom May 29, 2020
Merged
[vcpkg] Rename the msbuild property VcpkgRoot#11653BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal merged 1 commit intomicrosoft:masterfrom
Conversation
…dDir, and set VcpkgRoot to the expected root instead.
BillyONeal
commented
May 29, 2020
strega-nil
approved these changes
May 29, 2020
Contributor
strega-nil
left a comment
There was a problem hiding this comment.
Also, were there really no other uses of VcpkgRoot anywhere?
| { | ||
| return Strings::format(R"###( | ||
| <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> |
Contributor
There was a problem hiding this comment.
Is there a reason we don't have to export this?
Member
Author
There was a problem hiding this comment.
The file imported is $/scripts/buildsystems/msbuild/vcpkg.targets so the vcpkg root is already known from that. It might be an optimization to set the path here but I don't want to significantly change function if I don't have to.
Member
Author
Correct. |
Jinming-Hu
added a commit
to Jinming-Hu/azure-storage-cpp
that referenced
this pull request
Jun 14, 2020
Jinming-Hu
added a commit
to Jinming-Hu/azure-storage-cpp
that referenced
this pull request
Jun 14, 2020
Jinming-Hu
added a commit
to Azure/azure-storage-cpp
that referenced
this pull request
Jun 15, 2020
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…dDir, and set VcpkgRoot to the expected root instead. (microsoft#11653)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to VcpkgCurrentInstalledDir, and set VcpkgRoot to the expected root instead.