Skip to content

migrate to Node 16#332

Merged
AndreyIvanov42 merged 1 commit into
masterfrom
users/v-andivanov/migrate-to-node-16
Jul 19, 2022
Merged

migrate to Node 16#332
AndreyIvanov42 merged 1 commit into
masterfrom
users/v-andivanov/migrate-to-node-16

Conversation

@AndreyIvanov42

@AndreyIvanov42 AndreyIvanov42 commented Jul 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Task description

Update the library to check compatibility with Node 16

Changelog

  • Added Node 16 to a pipeline

Testing

  • Changes have been tested on Linux, MacOS, Windows by unit-tests
  • Client has been tested manually on NodeTool task with Node 16 runtime
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • I didn't find any breaking changes
  • There are no other concerns
  • I haven't discovered any new uncovered test/use cases

@AndreyIvanov42 AndreyIvanov42 added enhancement dependencies Pull requests that update a dependency file labels Jul 1, 2022
@AndreyIvanov42 AndreyIvanov42 requested a review from a team July 12, 2022 09:58
localconst
localconst reviewed Jul 12, 2022
View reviewed changes
Comment thread package.json Outdated
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/migrate-to-node-16 branch 2 times, most recently from 2d02844 to 5e93d7a Compare July 15, 2022 10:08
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/migrate-to-node-16 branch from 5e93d7a to f6843ce Compare July 15, 2022 10:36
@AndreyIvanov42 AndreyIvanov42 requested a review from mmrazik July 18, 2022 16:16
@AndreyIvanov42 AndreyIvanov42 merged commit 7892e05 into master Jul 19, 2022
@AndreyIvanov42 AndreyIvanov42 deleted the users/v-andivanov/migrate-to-node-16 branch August 23, 2022 07:18
ajuanjojjj pushed a commit to ajuanjojjj/typed-rest-client that referenced this pull request Jul 5, 2024
@AndreyIvanov42 @ajuanjojjj
added Node 16 to pipeline (microsoft#332)
5d62809
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmrazik mmrazik Awaiting requested review from mmrazik

5 more reviewers

@vmapetr vmapetr vmapetr approved these changes

@localconst localconst localconst approved these changes

@rumyax rumyax rumyax approved these changes

@wojgasior wojgasior wojgasior approved these changes

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AndreyIvanov42 @vmapetr @localconst @rumyax @wojgasior @kirill-ivlev