Skip to content

Fix CI after image update to a stable VS#6863

Merged
Youssef1313 merged 3 commits intomainfrom
dev/ygerges/fix-ci
Nov 3, 2025
Merged

Fix CI after image update to a stable VS#6863
Youssef1313 merged 3 commits intomainfrom
dev/ygerges/fix-ci

Conversation

@Youssef1313
Copy link
Member

No description provided.

Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^

@Youssef1313
Copy link
Member Author

Alternatively, we need to refactor our pipeline to avoid calling into eng\common\CIBuild.cmd directly so that we have a chance using our own scripts that does similar thing as Roslyn, and do it only when -ci is used.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Nov 3, 2025

@nohwnd I hacked it for now so that it's CI-only.

Eventually I would like one of the following to happen:

  1. SDK is able to tell from global.json that it should allow prerelease.
  2. This hack is integrated into Arcade, so we eventually remove it.

@Youssef1313 Youssef1313 requested a review from nohwnd November 3, 2025 11:13
@Youssef1313 Youssef1313 merged commit 337c579 into main Nov 3, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/fix-ci branch November 3, 2025 12:57
@Youssef1313
Copy link
Member Author

/backport to rel/3.11

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Started backporting to rel/3.11: https://github.com/microsoft/testfx/actions/runs/19169188036

Youssef1313 added a commit that referenced this pull request Nov 7, 2025
…ckport to rel/3.11) (#6905)

Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>
@Youssef1313
Copy link
Member Author

/backport to rel/4.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Started backporting to rel/4.0: https://github.com/microsoft/testfx/actions/runs/19173053174

Youssef1313 added a commit that referenced this pull request Nov 7, 2025
…ckport to rel/4.0) (#6913)

Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants