Merged
Conversation
Youssef1313
commented
Sep 8, 2025
Member
Author
|
/backport to rel/3.10 |
Contributor
|
Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/17557666260 |
Contributor
|
@Youssef1313 backporting to rel/3.10 failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Avoid long path issues for pipes
Using index info to reconstruct a base tree...
M src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServer.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServer.cs
CONFLICT (content): Merge conflict in src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServer.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Avoid long path issues for pipes
Error: The process '/usr/bin/git' failed with exit code 128NOTE: A PR will be created, but needs to be revised manually! |
This was referenced Sep 8, 2025
Merged
Member
Author
|
/backport to rel/3.10 |
Contributor
|
Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/17562662157 |
Evangelink
approved these changes
Sep 9, 2025
drognanar
reviewed
Sep 9, 2025
| ; | ||
| #pragma warning restore CA1416 // Validate platform compatibility | ||
|
|
||
| private static bool IsUnix => Path.DirectorySeparatorChar == '/'; |
Member
There was a problem hiding this comment.
why have we moved to a simple separator check, rather than RuntimeInformation.IsOSPlatform?
Member
Author
There was a problem hiding this comment.
I preferred to follow what Roslyn does which we know works very well for them.
But it's probably equivalent.
DirectorySeparatorChar on dotnet/runtime is hard coded on Windows to \ and on Unix to /.
Youssef1313
added a commit
that referenced
this pull request
Sep 9, 2025
…o rel/3.10) (#6538) Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6535