Don't keep MTP process alive if pipe disconnects#6477
Merged
Youssef1313 merged 1 commit intomainfrom Sep 1, 2025
Merged
Conversation
Member
Author
|
/backport to rel/3.10 |
Contributor
|
Started backporting to rel/3.10: https://github.com/microsoft/testfx/actions/runs/17371740816 |
mariam-abdulla
approved these changes
Sep 1, 2025
| // This can happen if the other processes gets killed or crashes while while it's sending the response. | ||
| // This is especially important for 'dotnet test', where the user can simply kill the dotnet.exe process themselves. | ||
| // In that case, we want the MTP process to also die. | ||
| _environment.FailFast("[NamedPipeClient] Connection lost with the other side."); |
Member
There was a problem hiding this comment.
what does this do? Does this actually call Environment.FailFast()? Beware that this may generate a dump of the current process, if the LocalDumps registry key is enabled:
https://github.com/KirillOsenkov/dotfiles/blob/main/LocalDumps.reg
or Azure Watson might be listening too.
Not sure if this is desired, perhaps just do Environment.Exit()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6475