Skip to content

Move IDataConsumer from Microsoft.Testing.Platform.Extensions.TestHost to Microsoft.Testing.Platform.Extensions namespace #6035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Evangelink merged 9 commits into from
Jul 16, 2025
Merged

Move IDataConsumer from Microsoft.Testing.Platform.Extensions.TestHost to Microsoft.Testing.Platform.Extensions namespace #6035

Evangelink merged 9 commits into from
Jul 16, 2025

Conversation

Copy link
Contributor

Copilot AI commented Jul 15, 2025 •
edited
Loading

The IDataConsumer interface was previously located in the Microsoft.Testing.Platform.Extensions.TestHost namespace and inherited from ITestHostExtension, which limited its usage to TestHost-specific implementations. Since IDataConsumer can be implemented in other hosts as well, this PR moves it to the root Microsoft.Testing.Platform.Extensions namespace.

Changes Made

1. Interface Location and Inheritance

  • Moved IDataConsumer.cs from src/Platform/Microsoft.Testing.Platform/Messages/ to src/Platform/Microsoft.Testing.Platform/Extensions/
  • Updated namespace from Microsoft.Testing.Platform.Extensions.TestHost to Microsoft.Testing.Platform.Extensions
  • Changed inheritance from ITestHostExtension to IExtension to make it available for other hosts

2. Updated References

Updated all source files, test files, and sample files to use the new namespace:

  • Added using Microsoft.Testing.Platform.Extensions; statements where needed
  • Updated 30 files across the codebase including:
    • Core platform files (22 files)
    • Test files (4 files)
    • Sample files (3 files)
    • PublicAPI.Shipped.txt (1 file)

3. Public API Changes

Updated PublicAPI.Shipped.txt to reflect the new namespace:

- Microsoft.Testing.Platform.Extensions.TestHost.IDataConsumer
+ Microsoft.Testing.Platform.Extensions.IDataConsumer

Benefits

  • Broader Usage: IDataConsumer can now be implemented in any host type, not just TestHost
  • Better Organization: Interface is now in the root Extensions namespace alongside other general extension interfaces
  • Consistent Design: Aligns with the principle that extensions should be host-agnostic when possible

Breaking Changes

This is a breaking change for consumers who directly reference the old namespace. However, the interface contract and functionality remain identical - only the namespace import needs to be updated.

Fixes #3354.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 15, 2025

@copilot Please target rel/4.0 branch

Copilot AI changed the title [WIP] Microsoft.Testing.Platform.Extensions.TestHost.IDataConsumer should be defined inside the Microsoft.Testing.Platform.Extensions Move IDataConsumer from Microsoft.Testing.Platform.Extensions.TestHost to Microsoft.Testing.Platform.Extensions namespace Jul 15, 2025
Copilot AI requested a review from Youssef1313 July 15, 2025 14:35
Copy link
Contributor Author

Copilot AI commented Jul 15, 2025

@copilot Please target rel/4.0 branch

I've created a new branch copilot/fix-3354-rel-4.0 that targets the rel/4.0 branch and applied the same changes there. The PR now targets the correct branch with commit d62629b.

@Youssef1313 Youssef1313 changed the base branch from main to rel/4.0 July 15, 2025 15:01
@Youssef1313
Copy link
Member

Youssef1313 commented Jul 15, 2025 •
edited
Loading

@Evangelink @MarcoRossignoli I think this should be Microsoft.Testing.Platform.Extensions.TestHost not Microsoft.Testing.Platform.Extensions. Do you agree? Edit: Not correct.

@Youssef1313
Move IDataConsumer from Microsoft.Testing.Platform.Extensions.TestHos…
89ad4a8 
…t to Microsoft.Testing.Platform.Extensions namespace

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 15, 2025

@Evangelink @MarcoRossignoli I think this should be Microsoft.Testing.Platform.Extensions.TestHost not Microsoft.Testing.Platform.Extensions. Do you agree? Edit: Not correct.

I've moved IDataConsumer back to the Microsoft.Testing.Platform.Extensions.TestHost namespace as requested. The interface now:

  1. Resides in the Microsoft.Testing.Platform.Extensions.TestHost namespace
  2. Inherits from ITestHostExtension instead of IExtension
  3. Is located in the src/Platform/Microsoft.Testing.Platform/TestHost/ directory
  4. All references across the codebase have been updated accordingly

The changes are in commit 0106db1.

@Youssef1313
Remove unnecessary using statement for Microsoft.Testing.Platform.Ext…
d066e95 
…ensions.TestHost

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot AI requested a review from Youssef1313 July 15, 2025 15:50
@Youssef1313
Copy link
Member

Youssef1313 commented Jul 15, 2025

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs(7,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0005)

@Youssef1313
Remove unnecessary using statements for Microsoft.Testing.Platform.Ex…
ba28065 
…tensions.TestHost

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
@Youssef1313
Remove unnecessary using statement for Microsoft.Testing.Platform.Ext…
536f0e9 
…ensions.TestHost in AbortForMaxFailedTestsExtension.cs

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 15, 2025

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs(7,1): error IDE0005: (NETCORE_ENGINEERING_TELEMETRY=Build) Using directive is unnecessary. (https://learn.micros...

Removed the unnecessary using statement for Microsoft.Testing.Platform.Extensions.TestHost from AbortForMaxFailedTestsExtension.cs in commit 536f0e9.

@Youssef1313
Revert PublicAPI.Shipped.txt changes for IDataConsumer namespace
00a826c 
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot AI requested a review from Youssef1313 July 15, 2025 16:40
@Youssef1313 Youssef1313 marked this pull request as ready for review July 15, 2025 17:17
@Evangelink Evangelink merged commit d7122ba into rel/4.0 Jul 16, 2025
9 checks passed
@Evangelink Evangelink deleted the copilot/fix-3354 branch July 16, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Evangelink Evangelink approved these changes

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

Assignees

@Youssef1313 Youssef1313

Copilot code review Copilot

Labels

Breaking ‼️

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Microsoft.Testing.Platform.Extensions.TestHost.IDataConsumer should be defined inside the Microsoft.Testing.Platform.Extensions

3 participants

@Youssef1313 @Evangelink