Remove ClassCleanupBehavior.EndOfAssembly
#1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e5b5740.
ClassCleanupBehavior.EndOfAssemblyClassCleanupBehavior.EndOfAssembly
engyebrahim
commented
Feb 1, 2023
test/IntegrationTests/MSTest.VstestConsoleWrapper.IntegrationTests/SuiteLifeCycleTests.cs
Show resolved
Hide resolved
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ClassCleanupBehavior.EndOfAssemblyClassCleanupBehavior.EndOfAssembly
Evangelink
reviewed
Feb 1, 2023
src/TestFramework/TestFramework/Attributes/Lifecycle/Cleanup/ClassCleanupBehavior.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 1, 2023
Member
Evangelink
left a comment
There was a problem hiding this comment.
I will do a debugging session tomorrow to check the throw part and if there are some more part that can be removed.
Evangelink
reviewed
Feb 2, 2023
d0765bb to
b8ca083
Compare
Evangelink
reviewed
Feb 2, 2023
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Shipped.txt
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Feb 3, 2023
Member
|
Nice work @engyebrahim |
engyebrahim
added a commit
to engyebrahim/testfx
that referenced
this pull request
May 16, 2023
This reverts commit 6ededf0. # Conflicts: # src/Adapter/MSTest.TestAdapter/Execution/TestClassInfo.cs # src/Adapter/MSTest.TestAdapter/Execution/UnitTestRunner.cs # src/Adapter/MSTest.TestAdapter/PublicAPI/PublicAPI.Shipped.txt # src/TestFramework/TestFramework/Attributes/Lifecycle/Cleanup/ClassCleanupBehavior.cs # src/TestFramework/TestFramework/Attributes/Lifecycle/Cleanup/ClassCleanupExecutionAttribute.cs # src/TestFramework/TestFramework/PublicAPI/PublicAPI.Shipped.txt # test/IntegrationTests/MSTest.VstestConsoleWrapper.IntegrationTests/SuiteLifeCycleTests.cs # test/IntegrationTests/TestAssets/SuiteLifeCycleTestProject/LifeCycleClassCleanupEndOfAssemblyAndBeforeEachDerivedClass.cs # test/IntegrationTests/TestAssets/SuiteLifeCycleTestProject/LifeCycleClassCleanupEndOfAssemblyAndNone.cs # test/IntegrationTests/TestAssets/SuiteLifeCycleTestProject/LifeCycleDerivedClassCleanupEndOfAssemblyAndBeforeEachDerivedClass.cs # test/IntegrationTests/TestAssets/SuiteLifeCycleTestProject/LifeCycleDerivedClassCleanupEndOfAssemblyAndNone.cs # test/UnitTests/MSTestAdapter.UnitTests/Execution/TestClassInfoTests.cs
engyebrahim
added a commit
that referenced
this pull request
May 17, 2023
This reverts commit 6ededf0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1574 and relates to #1541