Merged
Conversation
zadjii-msft
approved these changes
Mar 30, 2021
DHowett
approved these changes
Mar 30, 2021
Member
DHowett
left a comment
There was a problem hiding this comment.
Okay. We can revert this or look at the original code when we want to bring it back. Which we will.
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Member
|
I am glad that this will conflict with 1.7 because of the xaml reformatting -.- |
DHowett
pushed a commit
that referenced
this pull request
Apr 2, 2021
Removes base layer (aka profiles.defaults) from the Settings UI. `SettingContainer` was also updated to not present a revert arrow when overriding a base layer value. The new experience is now as follows: - The revert arrow will only appear if you are overriding a value from a fragment extension. - Users are still able to fully interact with `profiles.defaults` in their settings.json. Doing so still propagates those changes to their profiles as normal. In this case, the Settings UI presents the base layer value as the one that you selected. Closes #9539 (cherry picked from commit 19fb9b2)
|
🎉 Handy links: |
|
🎉 Handy links: |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes base layer (aka profiles.defaults) from the Settings UI.
SettingContainerwas also updated to not present a revert arrow when overriding a base layer value.The new experience is now as follows:
profiles.defaultsin their settings.json. Doing so still propagates those changes to their profiles as normal. In this case, the Settings UI presents the base layer value as the one that you selected.#6800 - Settings UI Epic
Closes #9539