Reset the size param between split-pane subcommands#8753
Merged
1 commit merged intomainfrom Jan 12, 2021
Merged
Conversation
DHowett
approved these changes
Jan 12, 2021
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 40 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
Jan 12, 2021
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
## Summary of the Pull Request I forgot to reset the `--size` argument to `split-pane` when I added it. This PR fixes that, and adds a test so I don't regress it again. ## References * Missed in microsoft#8543 ## PR Checklist * [x] I work here * [x] Tests added/passed
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
I forgot to reset the
--sizeargument tosplit-panewhen I added it. This PR fixes that, and adds a test so I don't regress it again.References
sizeparam tosplitPaneaction,split-panesubcommand #8543PR Checklist