Skip to content

Make schema compliant by fixing CloseTab* index definitions#8547

Merged
DHowett merged 1 commit intomicrosoft:mainfrom
Don-Vito:8024-fix-schema
Dec 11, 2020
Merged

Make schema compliant by fixing CloseTab* index definitions#8547
DHowett merged 1 commit intomicrosoft:mainfrom
Don-Vito:8024-fix-schema

Conversation

@Don-Vito
Copy link
Contributor

@Don-Vito Don-Vito commented Dec 10, 2020

Detailed Description of the Pull Request / Additional comments

  • The index field should be of type "null" and not null.
  • The default value should be null and not ""

@ghost ghost added Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Dec 10, 2020
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DHowett
Copy link
Member

DHowett commented Dec 10, 2020

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 10, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 10 Dec 2020 20:36:47 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@zadjii-msft zadjii-msft self-assigned this Dec 10, 2020
@DHowett DHowett merged commit 4111be3 into microsoft:main Dec 11, 2020
mpela81 pushed a commit to mpela81/terminal that referenced this pull request Jan 28, 2021
…t#8547)

* The index field should be of type `"null"` and not `null`.
* The default value should be `null` and not `""`

Closes microsoft#8024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Schema Things that have to do with the json schema. AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

{ "type": null } in profiles.schema.json violates JSON Schema draft 2019-09 meta-schema

4 participants