Merged
Conversation
Don-Vito
reviewed
Dec 8, 2020
Don-Vito
reviewed
Dec 9, 2020
| // it'll get fired twice, once when the key is pressed to commit/cancel, | ||
| // and then again when the focus is lost | ||
|
|
||
| TraceLoggingWrite( |
Contributor
There was a problem hiding this comment.
The only nit is do we want to put the log in the end of the method, after the box is actually closed?
Member
There was a problem hiding this comment.
Nah -- since this function is unlikely to fail between now and then 😄
Don-Vito
approved these changes
Dec 9, 2020
Contributor
Don-Vito
left a comment
There was a problem hiding this comment.
FWIW I like it (not sure if the nit I mentioned is relevant)
DHowett
approved these changes
Dec 10, 2020
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
carlos-zamora
approved these changes
Dec 10, 2020
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
We've got similar logging around the command palette, we really should have the same logging on the tab renamer as well. ## PR Checklist * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed  Look, it works
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've got similar logging around the command palette, we really should have the same logging on the tab renamer as well.
PR Checklist
Validation Steps Performed
Look, it works