Skip to content

Fix a deadlock during cooked reads#19994

Merged
DHowett merged 2 commits intomainfrom
dev/lhecker/19922-cooked-deadlock
Mar 19, 2026
Merged

Fix a deadlock during cooked reads#19994
DHowett merged 2 commits intomainfrom
dev/lhecker/19922-cooked-deadlock

Conversation

@lhecker
Copy link
Copy Markdown
Member

@lhecker lhecker commented Mar 19, 2026

Closes #19922

Validation Steps Performed

  • The repro now works as expected ✅
    (CreatePseudoConsole({1,20}) + WriteFile("キ"))

github-advanced-security[bot]
github-advanced-security AI found potential problems Mar 19, 2026
View reviewed changes
Comment thread src/host/readDataCooked.cpp Fixed
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.25 Servicing Pipeline Mar 19, 2026
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.24 Servicing Pipeline Mar 19, 2026
@github-actions

This comment has been minimized.

Sign in to view
@DHowett DHowett enabled auto-merge (squash) March 19, 2026 16:07
@DHowett DHowett merged commit ddf514e into main Mar 19, 2026
20 checks passed
@DHowett DHowett deleted the dev/lhecker/19922-cooked-deadlock branch March 19, 2026 17:31
@gcrtnst gcrtnst mentioned this pull request Mar 21, 2026
Open
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.24 Servicing Pipeline Mar 30, 2026
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.25 Servicing Pipeline Mar 30, 2026
DHowett pushed a commit that referenced this pull request Mar 30, 2026
@lhecker @DHowett
Fix a deadlock during cooked reads (#19994)
9634784 
Closes #19922

## Validation Steps Performed
* The repro now works as expected ✅
  (`CreatePseudoConsole({1,20})` + `WriteFile("キ")`)

(cherry picked from commit ddf514e)
Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgn2sRY
Service-Version: 1.24
DHowett pushed a commit that referenced this pull request Mar 30, 2026
@lhecker @DHowett
Fix a deadlock during cooked reads (#19994)
74f3bb4 
Closes #19922

## Validation Steps Performed
* The repro now works as expected ✅
  (`CreatePseudoConsole({1,20})` + `WriteFile("キ")`)

(cherry picked from commit ddf514e)
Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgn2sRU
Service-Version: 1.25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DHowett DHowett DHowett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

1.24 Servicing Pipeline
Status: Cherry Picked
1.25 Servicing Pipeline
Status: Cherry Picked

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ConPTY hangs or enters infinite loop when writing a 2-column character to a 1-column wide terminal

3 participants

@lhecker @DHowett @github-advanced-security