Fix selection markers disappearing after scrolling out of view#19974
Merged
Fix selection markers disappearing after scrolling out of view#19974
Conversation
DHowett
approved these changes
Mar 16, 2026
carlos-zamora
added a commit
that referenced
this pull request
Mar 31, 2026
## Summary of the Pull Request Updates the scroll handler to check the selection mode before updating the markers. Introduced in #19974 ## Validation Steps Performed `ls` --> create selection --> scroll away and back ✅ keyboard selection: markers are present both times ✅ mouse selection: markers are missing both times
DHowett
pushed a commit
that referenced
this pull request
Mar 31, 2026
## Summary of the Pull Request Updates the scroll handler to check the selection mode before updating the markers. Introduced in #19974 ## Validation Steps Performed `ls` --> create selection --> scroll away and back ✅ keyboard selection: markers are present both times ✅ mouse selection: markers are missing both times (cherry picked from commit 3104c8f) Service-Card-Id: PVTI_lADOAF3p4s4BQX0-zgo0IB8 Service-Version: 1.25
DHowett
pushed a commit
that referenced
this pull request
Apr 3, 2026
## Summary of the Pull Request Updates the scroll handler to check the selection mode before updating the markers. Introduced in #19974 ## Validation Steps Performed `ls` --> create selection --> scroll away and back ✅ keyboard selection: markers are present both times ✅ mouse selection: markers are missing both times (cherry picked from commit 3104c8f) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgo0ICA Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Pretty straightforward
Validation Steps Performed
✅ Selection markers are present after scrolling them out of view and scrolling back
Closes #17135