Standardize use of NavigateToPageArgs in SUI#19831
Merged
Conversation
Member
Author
|
Fun fact: GH Copilot was super useful here. I was actually able to point it to #19519 and tell it to port the specific change over. It was like 80% successful (it wanted to refactor at one point for some reason). |
DHowett
reviewed
Feb 6, 2026
DHowett
reviewed
Feb 6, 2026
DHowett
approved these changes
Feb 10, 2026
carlos-zamora
added a commit
that referenced
this pull request
Feb 25, 2026
## Summary of the Pull Request Consolidates the navigation functions in `MainPage` for the settings UI. This involved: - combining all separate `_Navigate()` functions into one big one - deduplicating `SettingsNav().SelectedItem()` calls - removing the unnecessary variable for a crumb (just inline creation and registration) - removing the `elementToFocus` staging behavior for color schemes and profile sub pages ## References and Relevant Issues Builds off the work done in #19519 and #19831 ## Validation Steps Performed Navigate to... ✅ simple top-level pages: Startup, Interaction, Appearance, Rendering, Compatibility, Add profile ✅ Color schemes and subpages ✅ Actions, subpages ✅ New Tab Menu and folder subpages ✅ Extensions, subpages, and profile/scheme navigation ✅ defaults profile and subpages ✅ specific profile and subpages Also tested discarding changes on these pages. ✅ search still works and navigates to the correct element ## PR Checklist Closes #19866
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Replaces usage of
NavigateToXArgsin theTerminalSettingsEditorwithNavigateToPageArgs. They all did pretty much the same thing anyways.References and Relevant Issues
Builds on #19826
Pulled out from #19519
Validation Steps Performed
✅ Navigated through all the SUI pages and subpages