Allow searching through the available shortcut actions in the EditAction page#19827
Merged
Allow searching through the available shortcut actions in the EditAction page#19827
Conversation
Contributor
Author
|
On first click (no filtering done yet, show all shortcut action types): Updated search results after user types: |
DHowett
requested changes
Feb 6, 2026
carlos-zamora
added a commit
that referenced
this pull request
Feb 10, 2026
…ns in the EditAction page
DHowett
requested changes
Feb 11, 2026
Member
DHowett
left a comment
There was a problem hiding this comment.
Ah, I was thinking more like... we make the allActions list once on navigation and cache that. and then we create _filteredActions based on that.
Right now, this will keep updating ...filtered to be smaller and smaller and e.g. deleting characters from the search won't bring old entries back right? Maybe I've read the code wrong :)
Member
|
thank you for letting me know |
DHowett
approved these changes
Feb 12, 2026
DHowett
reviewed
Feb 12, 2026
DHowett
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the
FontFaceBox, show all the available shortcut actions when the user clicks theShortcutActionBox, and filter the results based on the user's search query