Update actions page and edit actions page with better alignment by PankajBhojwani · Pull Request #19822 · microsoft/terminal

PankajBhojwani · 2026-01-30T23:58:24Z

Actions page: entries now stretch across the screen horizontally (to a max of 1000) to be consistent with other settings pages
Edit action page:
Keybindings and Additional arguments are now top-aligned headers
All arg templates now also stretch across the screen horizontally to match how expanders look in the rest of the settings UI

Validation Steps Performed

Everything still works. Screenshots below.

.claude/settings.local.json

@@ -0,0 +1,7 @@
+{


Backspace_Flow_Explained.md

+
+DirectX presents the frame to the display:
+```cpp
+_swapChain->Present(1, 0); // Vsync enabled


Backspace_Flow_Explained.md

+### Middle of Line
+
+```
+Before: "He█llo"  (cursor after 'e')


Backspace_Flow_Explained.md

+```
+Before: "He█llo"  (cursor after 'e')
+Press Backspace
+After:  "H█llo"   (cursor after 'H')


Backspace_Flow_Explained.md

+```
+\x1b[D     ← Move cursor left
+\x1b[K     ← Erase to end
+llo        ← Rewrite remaining text


VT_Sequences_Explained.md

+- **curses** - Python bindings for ncurses
+
+**Rust:**
+- **termion** - Terminal manipulation


VT_Sequences_Explained.md

+
+**Rust:**
+- **termion** - Terminal manipulation
+- **crossterm** - Cross-platform terminal library


WindowsTerminal_Architecture.md

+│  └──────────────────────────────────────┘              │
+│                                                         │
+│  DirectX 11 Pipeline:                                  │
+│  1. Rasterize glyphs with DirectWrite                  │


WindowsTerminal_Architecture.md

+  IRenderEngine::PaintBufferLine()
+         ↓
+AtlasEngine:
+  • Looks up/rasterizes glyphs


WindowsTerminal_Architecture.md

+- `IRenderData` for rendering data access
+- `IRenderEngine` for rendering backend abstraction
+- `ITerminalInput` for input handling
+- Enables pluggability and testability


PankajBhojwani · 2026-01-31T00:06:05Z

narrow:

carlos-zamora

I like the new layout. The headers look nice and make it clear that there's different sections.

I think the spacing needs to be adjusted a little bit though. Here's some notes:

Spacing:
- spacing beneath headers (i.e. "Command details", "Keybindings", and "Additional arguments") is a little too large. Looks like it's ~40 for "command details" and "additional arguments", but ~24 for "Keybindings".
  - I recommend ~12 (WinUI 3 gallery says "12 - between control + header, surface and edge text, text sections")
- Spacing between keybinding and "Additional arguments" is ~26.
  - I recommend ~16 (WinUI 3 gallery says "16 - used in list styles, cards")
- Spacing between "action name" and "action type" (and repeat for spacing between keybindings and each arg) is currently ~16 (~8 for keybindings and additional args)
  - I recommend ~8 consistently. I think keybindings and additional args look good as-is, so I'm kinda getting inspiration from there.
Alignment:
- delete button for keybindings feels really far away haha
  - recommendation: left align them. Maybe have it be a grid with 2 columns (key chords vs delete buttons) so that the delete buttons themselves are aligned with each other
- nit: "action name" and "action type" controls are aligned (nice), but they don't align with the ones in "additional arguments". Might be nice if they did?
- consider aligning the checkbox action args to the left. They feel a bit far away too haha.
Order:
- Consider moving the "add keybinding" button to after the key chords (instead of before).

All that said, I'm not a designer haha. I think these might be a good starting point though and you can adjust them from there?

I found a few resources that may be helpful:

WinUI 3 Gallery > Spacing page
https://learn.microsoft.com/en-us/windows/apps/design/basics/content-basics

Hope this all helps!

…r alignment

carlos-zamora

Downloaded the branch and it looks great. Just the one note on the column span to avoid wrapping the text for the headers. Especially since the localized strings may be longer.

I want to test it with a screen reader too, just to make sure it feels right.

@cinnamon-msft was also looking over my shoulder and suggesting that the additional arg labels (I.e. "Split Direction") should be renamed to use sentence casing ("Split direction") to match the rest of the UI. I agree. Mind doing that either as a part of this PR or a separate one?

src/cascadia/TerminalSettingsEditor/EditAction.xaml

PankajBhojwani · 2026-02-13T01:54:16Z

Mind doing that either as a part of this PR or a separate one?

Made a separate PR for it!

…19861) From the feedback received in #19822, update the multi-word additional argument resource entries to use sentence case.

carlos-zamora · 2026-02-13T17:28:15Z

Hmm... Something's up:

I wonder if the wrong row is being applied? I got this from the output from the build pipeline (unpackaged).

PankajBhojwani · 2026-02-13T18:15:41Z

I wonder if the wrong row is being applied?

Ah yeah that was from the merge conflict, thanks for catching it! Fixed

carlos-zamora · 2026-02-13T20:15:41Z

Hmm... Looks like the wrong header is being used for the keybindings section.

carlos-zamora

Tested w/ Narrator and it's a really nice experience. Visually looks great too. Nice work :)

alignments

d955d44

github-advanced-security bot found potential problems Jan 30, 2026

View reviewed changes

remove these artifacts

a2e24f0

format

3dc426d

carlos-zamora requested changes Feb 3, 2026

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 3, 2026

carlos-zamora added the zBugBash-Consider label Feb 10, 2026

carlos-zamora added a commit that referenced this pull request Feb 10, 2026

PRE-MERGE #19822 Update actions page and edit actions page with bette…

f3b7ff2

…r alignment

PankajBhojwani added 3 commits February 11, 2026 14:55

address carlos visual feedback

a4492d7

format

540d3f3

this to the left too

768a4e9

microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 11, 2026

PankajBhojwani requested a review from carlos-zamora February 11, 2026 23:23

don't need this margin anymore

9d49851

carlos-zamora reviewed Feb 12, 2026

View reviewed changes

src/cascadia/TerminalSettingsEditor/EditAction.xaml Show resolved Hide resolved

PankajBhojwani added 2 commits February 12, 2026 17:11

column span 2 for these headers

558b2a0

conflict

592b1bb

PankajBhojwani mentioned this pull request Feb 13, 2026

Use sentence case for actions' additional argument resource strings #19861

Merged

DHowett pushed a commit that referenced this pull request Feb 13, 2026

Use sentence case for actions' additional argument resource strings (#…

1f85191

…19861) From the feedback received in #19822, update the multi-word additional argument resource entries to use sentence case.

correct row

eed7f41

header fix

3a55ea7

carlos-zamora approved these changes Feb 13, 2026

View reviewed changes

carlos-zamora merged commit 830935d into main Feb 13, 2026
18 of 20 checks passed

carlos-zamora deleted the dev/pabhoj/actions_editor_visual branch February 13, 2026 22:52

Conversation

PankajBhojwani commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validation Steps Performed

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

PankajBhojwani commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PankajBhojwani commented Feb 13, 2026

Uh oh!

carlos-zamora commented Feb 13, 2026

Uh oh!

PankajBhojwani commented Feb 13, 2026

Uh oh!

carlos-zamora commented Feb 13, 2026

Uh oh!

carlos-zamora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

PankajBhojwani commented Jan 30, 2026 •

edited

Loading

PankajBhojwani commented Jan 31, 2026 •

edited

Loading