Wrap window shutdown in a top-level exception handler#19743
Merged
Conversation
The resources were going to leak either way; this just allows us to keep closer track of the window count and--critically--exit terminal when it hits 0. Closes #19446
lhecker
approved these changes
Jan 15, 2026
DHowett
added a commit
that referenced
this pull request
Jan 15, 2026
(cherry picked from commit a0c79b5) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgjsATs Service-Version: 1.24
DHowett
added a commit
that referenced
this pull request
Jan 15, 2026
(cherry picked from commit a0c79b5) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgjsATw Service-Version: 1.23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resources were going to leak either way; this just allows us to keep closer track of the window count and--critically--exit terminal when it hits 0.
Closes #19446