Allow creating new windows on another virtual desktop#19458
Merged
Conversation
0409c25 to
37bc6ed
Compare
DHowett
reviewed
Oct 16, 2025
lhecker
commented
Oct 16, 2025
| const auto mostRecent = mostRecentWeak.lock(); | ||
| auto window = mostRecent.get(); | ||
|
|
||
| if (!window) |
Member
Author
There was a problem hiding this comment.
@DHowett The fix is that this if-condition is gone. If the currentDesktop was acquired we must yield a window = nullptr if no window exists on the current desktop. This if-condition however will assign the most recent window.
DHowett
approved these changes
Oct 21, 2025
DHowett
pushed a commit
that referenced
this pull request
Nov 24, 2025
Whoops. Closes #18652 <DHowett> I chatted with Leonard to figure out why I kept misunderstanding this PR. The key is that **this function should not always return an existing window.** It's supposed to find an existing window on the current virtual desktop, not literally any window anywhere. (cherry picked from commit 5ae95d7) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgYvdmA Service-Version: 1.23
DHowett
pushed a commit
that referenced
this pull request
Nov 24, 2025
Whoops. Closes #18652 <DHowett> I chatted with Leonard to figure out why I kept misunderstanding this PR. The key is that **this function should not always return an existing window.** It's supposed to find an existing window on the current virtual desktop, not literally any window anywhere. (cherry picked from commit 5ae95d7) Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgf7tqY Service-Version: 1.24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whoops. Closes #18652