Skip to content

Avoid generating SSH profiles using stale memory#19354

Merged
DHowett merged 3 commits intomainfrom
dev/duhowett/fix-ssh-bugs
Sep 16, 2025
Merged

Avoid generating SSH profiles using stale memory#19354
DHowett merged 3 commits intomainfrom
dev/duhowett/fix-ssh-bugs

Conversation

@DHowett
Copy link
Member

@DHowett DHowett commented Sep 16, 2025

You can't return a string_view to a temporary. It's a miracle this ever worked.

Broken since inception in a5f9c85

Closes #19355

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@carlos-zamora
Copy link
Member

Mark for servicing?

@DHowett DHowett merged commit 46b9572 into main Sep 16, 2025
19 checks passed
DHowett added a commit that referenced this pull request Sep 16, 2025
You can't return a `string_view` to a temporary. It's a miracle this
ever worked.

Broken since inception in a5f9c85

Closes #19355

(cherry picked from commit 46b9572)
Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzge0HmE
Service-Version: 1.24
@DHowett DHowett deleted the dev/duhowett/fix-ssh-bugs branch November 20, 2025 19:46
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.24 Servicing Pipeline Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH profiles can be generated with hilarious corrupt names

2 participants