Skip to content

Fix right click on tabs closing them#19273

Merged
lhecker merged 2 commits intomainfrom
dev/lhecker/broken-tab-close
Sep 8, 2025
Merged

Fix right click on tabs closing them#19273
lhecker merged 2 commits intomainfrom
dev/lhecker/broken-tab-close

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Aug 25, 2025

I do not like this.

Validation Steps Performed

  • Enable close buttons on tabs
  • Open a tab
  • Close the tab with middle click
  • Open a tab
  • Right click the tab
  • Tab doesn't close, Menu opens ✅

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-2 A description (P2) labels Aug 25, 2025
@github-project-automation github-project-automation bot moved this to To Cherry Pick in 1.23 Servicing Pipeline Aug 25, 2025
@DHowett DHowett moved this from To Cherry Pick to To Consider in 1.23 Servicing Pipeline Aug 25, 2025
@DHowett
Copy link
Member

DHowett commented Aug 25, 2025

Marking this as "to consider" for cherry pick as it's too hot for 1.23 stable

Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
@lhecker lhecker enabled auto-merge (squash) September 8, 2025 22:36
@lhecker lhecker merged commit 4a34a76 into main Sep 8, 2025
17 of 19 checks passed
@DHowett DHowett moved this from To Cherry Pick to Cherry Picked in 1.24 Servicing Pipeline Sep 16, 2025
DHowett pushed a commit that referenced this pull request Sep 16, 2025
I do not like this.

## Validation Steps Performed
* Enable close buttons on tabs
* Open a tab
* Close the tab with middle click
* Open a tab
* Right click the tab
* Tab doesn't close, Menu opens ✅

(cherry picked from commit 4a34a76)
Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgeAlgM
Service-Version: 1.24
@DHowett DHowett deleted the dev/lhecker/broken-tab-close branch November 20, 2025 19:46
@DHowett DHowett moved this from To Consider to To Cherry Pick in 1.23 Servicing Pipeline Jan 21, 2026
@DHowett DHowett moved this from To Cherry Pick to Rejected in 1.23 Servicing Pipeline Jan 22, 2026
@fabiopedrosa
Copy link

Its been a year, and I'll still having work vanish because of a right click. any ETA on this getting released?

@DHowett DHowett moved this from Cherry Picked to Shipped in 1.24 Servicing Pipeline Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Projects

Status: Rejected

Development

Successfully merging this pull request may close these issues.

3 participants