Skip to content

fix: wrong term in zh-TW#18849

Closed
hms5232 wants to merge 1 commit intomicrosoft:mainfrom
hms5232:fix-term
Closed

fix: wrong term in zh-TW#18849
hms5232 wants to merge 1 commit intomicrosoft:mainfrom
hms5232:fix-term

Conversation

@hms5232
Copy link
Contributor

@hms5232 hms5232 commented Apr 28, 2025

Summary of the Pull Request

Fix wrong term in zh-TW.

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

The "default" should be translated as "預設" in zh-TW, "默認" is in zh-CN.

Validation Steps Performed

PR Checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated
    • If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated (if necessary)

I check the CONTRIBUTING.md and README.md, there seems no part about the localization improvement so I open a PR and edit file directly. If there are a better way, please tell me and close this PR. Thanks!

@hms5232
fix: wrong term in zh-TW
c9699c8 
default => 預設 (zh-TW) 默認(zh-CN)
@DHowett
Copy link
Member

DHowett commented Oct 7, 2025

I'm so sorry for the delay here. I missed this in my e-mails. I will file a bug on the localization team to make sure this string is updated.

@DHowett
Copy link
Member

DHowett commented Oct 7, 2025

I filed GCS-1128236 to inform the localization team.

@hms5232
Copy link
Contributor Author

hms5232 commented Oct 8, 2025

I'm so sorry for the delay here. I missed this in my e-mails. I will file a bug on the localization team to make sure this string is updated.

I filed GCS-1128236 to inform the localization team.

Thanks for your reply and help! I do not find how to contribute to localization in CONTRIBUTION.md, so that create this PR directly.

Seems that the localization has its tracker. Can I just close this PR now and wait for result from localization team?

@DHowett
Copy link
Member

DHowett commented Oct 8, 2025

You did everything correctly! Our localization process is difficult even for us to deal with. I'll leave your PR open until the localizations are updated, as a reminder to the team that the work is still ongoing.

Thank you

@DHowett DHowett mentioned this pull request Oct 15, 2025
Merged
DHowett pushed a commit that referenced this pull request Oct 15, 2025
@consvc
Localization Updates - main - 10/15/2025 02:48:19 (#19451)
7f6ab55 
Closes #18849
Closes #19412

Co-authored-by: Console Service Bot <consvc@microsoft.com>
DHowett pushed a commit that referenced this pull request Nov 24, 2025
@consvc @DHowett
Localization Updates - main - 10/15/2025 02:48:19 (#19451)
821eb1b 
Closes #18849
Closes #19412

Co-authored-by: Console Service Bot <consvc@microsoft.com>
(cherry picked from commit 7f6ab55)
Service-Card-Id: PVTI_lADOAF3p4s4Axadtzgf5KOw
Service-Version: 1.23
DHowett pushed a commit that referenced this pull request Nov 24, 2025
@consvc @DHowett
Localization Updates - main - 10/15/2025 02:48:19 (#19451)
9ab1b7b 
Closes #18849
Closes #19412

Co-authored-by: Console Service Bot <consvc@microsoft.com>
(cherry picked from commit 7f6ab55)
Service-Card-Id: PVTI_lADOAF3p4s4BBcTlzgf5KOs
Service-Version: 1.24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hms5232 @DHowett