Use RenderSettings for DECSET 2026 - Synchronized Output#18833
Merged
Conversation
DHowett
approved these changes
Apr 24, 2025
Collaborator
|
Still needs to be reset here: diff --git a/src/renderer/base/RenderSettings.cpp b/src/renderer/base/RenderSettings.cpp
index 371b591b3..2e8ae8d0c 100644
--- a/src/renderer/base/RenderSettings.cpp
+++ b/src/renderer/base/RenderSettings.cpp
@@ -46,9 +46,9 @@ void RenderSettings::RestoreDefaultSettings() noexcept
{
_colorTable = _defaultColorTable;
_colorAliasIndices = _defaultColorAliasIndices;
- // For now, DECSCNM is the only render mode we need to reset. The others are
- // all user preferences that can't be changed programmatically.
- _renderMode.reset(Mode::ScreenReversed);
+ // DECSCNM and Synchronized Output are the only render modes we need to reset.
+ // The others are all user preferences that can't be changed programmatically.
+ _renderMode.reset(Mode::ScreenReversed, Mode::SynchronizedOutput);
}
// Routine Description:I know this is unlikely to effect most people, but it matters to me because it causes Windows Terminal to register a failure in one of my test frameworks when verifying |
Member
Author
|
Ah thanks, I forgot about RIS. |
DHowett
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RenderSettingsalready storesDECSCNM(reversed screen),so it only makes sense to also store DECSET 2026 there.
Validation Steps Performed